Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for WebGL2 FramebufferTextureLayer #25814
Merged
Conversation
highfive
commented
Feb 20, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Feb 20, 2020
|
|
|
|
mmatyas
force-pushed the
szeged:mmatyas__webgl_fns_framebuf_texlayer
branch
from
0a8656b
to
3c38ace
|
Rebased and updated the tests. There aren't too many of them though, as this GL call mainly depends on Texture2D/3D implemented first, but the code itself is ready for review. |
mmatyas
changed the title
|
|
Adds support for `FramebufferTextureLayer` WebGL2 call. See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.4
mmatyas
force-pushed the
szeged:mmatyas__webgl_fns_framebuf_texlayer
branch
from
3c38ace
to
8389189
|
Rebased. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 4, 2020
…=jdm Add support for WebGL2 FramebufferTextureLayer Adds support for `FramebufferTextureLayer` WebGL2 call. See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.4 <!-- Please describe your changes on the following line: --> Depends on #25798. cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mmatyas commentedFeb 20, 2020
Adds support for
FramebufferTextureLayerWebGL2 call.See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.4
Depends on #25798.
cc @jdm @zakorgy
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors