Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect dom syntax error in window postmessage sameorigin test #25816

Merged
merged 1 commit into from Feb 21, 2020

Conversation

@gterzian
Copy link
Member

gterzian commented Feb 20, 2020

FIX #25808


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@gterzian
Copy link
Member Author

gterzian commented Feb 20, 2020

@jdm r?

@jdm
Copy link
Member

jdm commented Feb 20, 2020

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

📌 Commit 6c02e5d has been approved by jdm

@highfive highfive assigned jdm and unassigned paulrouget Feb 20, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

Testing commit 6c02e5d with merge 0dbdba1...

bors-servo added a commit that referenced this pull request Feb 20, 2020
Expect dom syntax error in window postmessage sameorigin test

<!-- Please describe your changes on the following line: -->

FIX #25808

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Feb 20, 2020

@jdm
Copy link
Member

jdm commented Feb 20, 2020

@bors-servo r-
Temporarily to keep the queue down.

@jdm
Copy link
Member

jdm commented Feb 20, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

📌 Commit 6c02e5d has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

Testing commit 6c02e5d with merge eacc024...

bors-servo added a commit that referenced this pull request Feb 20, 2020
Expect dom syntax error in window postmessage sameorigin test

<!-- Please describe your changes on the following line: -->

FIX #25808

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Feb 20, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

Testing commit 6c02e5d with merge 9f3fc7e...

bors-servo added a commit that referenced this pull request Feb 20, 2020
Expect dom syntax error in window postmessage sameorigin test

<!-- Please describe your changes on the following line: -->

FIX #25808

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2020

Testing commit 6c02e5d with merge c15323e...

@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2020

💔 Test failed - status-taskcluster

@gterzian
Copy link
Member Author

gterzian commented Feb 21, 2020

bors-servo added a commit that referenced this pull request Feb 21, 2020
Expect dom syntax error in window postmessage sameorigin test

<!-- Please describe your changes on the following line: -->

FIX #25808

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2020

Testing commit 6c02e5d with merge 7d24c56...

@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Feb 21, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2020

Testing commit 6c02e5d with merge fa02904...

bors-servo added a commit that referenced this pull request Feb 21, 2020
Expect dom syntax error in window postmessage sameorigin test

<!-- Please describe your changes on the following line: -->

FIX #25808

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Feb 21, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2020

Testing commit 6c02e5d with merge 9c3feb7...

@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 9c3feb7 to master...

@bors-servo bors-servo merged commit 9c3feb7 into servo:master Feb 21, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.