Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Impl ReadableStream support #25827

Closed
wants to merge 9 commits into from
Closed

Conversation

@gterzian
Copy link
Member

gterzian commented Feb 23, 2020

FIX #21482


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented Feb 23, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/parser/WebIDL.py, components/script/dom/mod.rs, components/script/dom/readablestream.rs, components/script/dom/webidls/ReadableStream.webidl
  • @KiChjang: components/script/dom/bindings/codegen/parser/WebIDL.py, components/script/dom/mod.rs, components/script/dom/readablestream.rs, components/script/dom/webidls/ReadableStream.webidl
@highfive
Copy link

highfive commented Feb 23, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
gterzian added 4 commits Feb 23, 2020
gterzian added 4 commits Feb 23, 2020
@gterzian
Copy link
Member Author

gterzian commented Feb 24, 2020

Closing this one because I'm pretty sure this is not the way to do it, see #21482 (comment)

@gterzian gterzian closed this Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.