Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove azure canvas backend #25841
Remove azure canvas backend #25841
Conversation
highfive
commented
Feb 25, 2020
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon. |
highfive
commented
Feb 25, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Feb 25, 2020
|
|
|
Unfortunately, as I'm on Fedora 31, I don't think I can currently actually build servo. I'll have to figure something out, maybe run Fedora 29/30 in a VM... |
| @@ -23,6 +23,7 @@ use webrender_api::units::RectExt as RectExt_; | |||
| /// further operations to it in device space. When it's time to | |||
| /// draw the path, we convert it back to userspace and draw it | |||
| /// with the correct transform applied. | |||
| /// TODO: De-abstract now that Azure is removed? | |||
This comment has been minimized.
This comment has been minimized.
dralley
Feb 25, 2020
Author
Contributor
I can remove these comments or change the format, I don't know what the plan is here.
This comment has been minimized.
This comment has been minimized.
dralley
Feb 25, 2020
•
Author
Contributor
Is de-abstracting these things also considered part of the issue?
This comment has been minimized.
This comment has been minimized.
SimonSapin
Feb 25, 2020
Member
Merging the code removing is a good step even if a now-unnecessary abstraction is still there. Leaving a TODO or FIXME comment is fine.
This comment has been minimized.
This comment has been minimized.
SimonSapin
Feb 25, 2020
Member
@pcwalton Do you think we should keep this abstraction around in case we want to add a Pathfinder backend at some point?
| use azure::azure_hl::{ AntialiasMode, Color, ColorPattern, CompositionOp }; | ||
| use azure::azure_hl::{AntialiasMode, Color, | ||
| use raqote::{GradientStop, Source, SolidSource}; | ||
| use raqote::{Source, SolidSource}, |
This comment has been minimized.
This comment has been minimized.
dralley
Feb 25, 2020
Author
Contributor
I just picked random structs, not sure if I'm still matching the intention of the tests.
This comment has been minimized.
This comment has been minimized.
dralley
Feb 25, 2020
Author
Contributor
@SimonSapin I just noticed -- I didn't preserve the extraneous whitespace on the first line here.
This comment has been minimized.
This comment has been minimized.
SimonSapin
Feb 25, 2020
Member
Does ./mach test-tidy --self-test succeed for you? If not adjust files until it does, make or amend commits, and push or force-push to this PR again.
|
Looks good, thanks! @bors-servo r+ |
|
|
|
|
dralley commentedFeb 25, 2020
•
edited
closes #25833
Issue description: Now that the raqote backend has reached feature parity and been enabled by default, we should remove the unused azure backend entirely.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors