Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly position atomic inline level boxes #25847

Merged
merged 1 commit into from Feb 27, 2020
Merged

Properly position atomic inline level boxes #25847

merged 1 commit into from Feb 27, 2020

Conversation

@ferjm
Copy link
Member

ferjm commented Feb 26, 2020

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #25709
@ferjm
Copy link
Member Author

ferjm commented Feb 26, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2020

⌛ Trying commit f3b5002 with merge 4e66e83...
bors-servo added a commit that referenced this pull request Feb 26, 2020
@bors-servo
Auto merge of #25847 - ferjm:issue.25709, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4e66e83 
Properly position atomic inline level boxes

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25709
@SimonSapin
SimonSapin approved these changes Feb 26, 2020
View changes
Copy link
Member

SimonSapin left a comment

Nice catch! r+ with one change to save a couple additions
components/layout_2020/flow/inline.rs Outdated
fragment.padding.block_sum() +
fragment.border.block_sum() +
fragment.margin.block_sum(),
Comment on lines 573 to 575

This comment has been minimized.

Sign in to view
@SimonSapin

SimonSapin Feb 26, 2020

Member

Nit: this is also pbm.block_sum()
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@ferjm ferjm force-pushed the ferjm:issue.25709 branch from f3b5002 to 34b0b30 Feb 26, 2020
@ferjm
Copy link
Member Author

ferjm commented Feb 26, 2020

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2020

📌 Commit 34b0b30 has been approved by SimonSapin
@ferjm ferjm added the A-layout/2020 label Feb 26, 2020
@SimonSapin
Copy link
Member

SimonSapin commented Feb 26, 2020

Sorry, let’s not land this as-is after all since it seems not to impact any test.

@bors-servo r-

In case this was because relevant tests are not enabled I’m trying this PR on top of #25849. It’s still running but looking good so far.
@SimonSapin
Copy link
Member

SimonSapin commented Feb 26, 2020

Look at that ✨

Ran 9459 tests finished in 598.0 seconds.
  • 8860 ran as expected. 0 tests skipped.
  • 15 tests failed unexpectedly
  • 583 tests passed unexpectedly
  • 1 tests had unexpected subtest results
@SimonSapin
Copy link
Member

SimonSapin commented Feb 26, 2020

Oh. An even less surprising explanation: the previous try run was testing Layout 2013

@bors-servo try=wpt-2020
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2020

⌛ Trying commit 34b0b30 with merge 082693a...
bors-servo added a commit that referenced this pull request Feb 26, 2020
@bors-servo
Auto merge of #25847 - ferjm:issue.25709, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
082693a 
Properly position atomic inline level boxes

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25709
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2020

💔 Test failed - status-taskcluster
@SimonSapin
Copy link
Member

SimonSapin commented Feb 26, 2020

Without #25849 this time, still awsome!

  • 3312 ran as expected. 0 tests skipped.
  • 1 tests had errors unexpectedly
  • 3 tests failed unexpectedly
  • 154 tests passed unexpectedly
  • 1 tests unexpectedly okay
  • 4 tests had unexpected subtest results

You should be able to find the test-wpt.log artifact from CI, click "Raw log" in the bottom right menu to find the URL https://community.taskcluster-artifacts.net/QhRdhd11RaedIfm_-oFY0g/0/public/test-wpt.log, then run ./mach update-wpt --layout-2020 with that file.
@SimonSapin
Copy link
Member

SimonSapin commented Feb 26, 2020

r+ with updated test expectations
@ferjm
Copy link
Member Author

ferjm commented Feb 26, 2020

Oh. An even less surprising explanation: the previous try run was testing Layout 2013

@bors-servo try=wpt-2020

Aha! TIL
@ferjm ferjm force-pushed the ferjm:issue.25709 branch from 8c496a1 to 69eaa48 Feb 26, 2020
@ferjm
Copy link
Member Author

ferjm commented Feb 26, 2020

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Feb 26, 2020

📌 Commit 69eaa48 has been approved by SimonSapin
@ferjm
Copy link
Member Author

ferjm commented Feb 27, 2020

@bors-servo try=wpt-2020
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

⌛ Trying commit 1902cd1 with merge 9ed7e66...
bors-servo added a commit that referenced this pull request Feb 27, 2020
@bors-servo
Auto merge of #25847 - ferjm:issue.25709, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9ed7e66 
Properly position atomic inline level boxes

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25709
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

💔 Test failed - status-taskcluster
@ferjm
Properly position atomic inline level boxes
Loading status checks…
48a4c07
@ferjm ferjm force-pushed the ferjm:issue.25709 branch from 1902cd1 to 48a4c07 Feb 27, 2020
@ferjm
Copy link
Member Author

ferjm commented Feb 27, 2020

@bors-servo try=wpt-2020
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

⌛ Trying commit 48a4c07 with merge 03d8c21...
bors-servo added a commit that referenced this pull request Feb 27, 2020
@bors-servo
Auto merge of #25847 - ferjm:issue.25709, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
03d8c21 
Properly position atomic inline level boxes

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25709
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@jdm
Copy link
Member

jdm commented Feb 27, 2020

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

📌 Commit 48a4c07 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

⌛ Testing commit 48a4c07 with merge 9a4e685...
bors-servo added a commit that referenced this pull request Feb 27, 2020
@bors-servo
Auto merge of #25847 - ferjm:issue.25709, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9a4e685 
Properly position atomic inline level boxes

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25709
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

💔 Test failed - status-taskcluster
@ferjm
Copy link
Member Author

ferjm commented Feb 27, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

⌛ Testing commit 48a4c07 with merge 756cf66...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 27, 2020

☀️ Test successful - status-taskcluster
Approved by: SimonSapin
Pushing 756cf66 to master...
@bors-servo bors-servo merged commit 756cf66 into servo:master Feb 27, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@ferjm ferjm deleted the ferjm:issue.25709 branch Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonSapin SimonSapin

Assignees

@SimonSapin SimonSapin

Labels
A-layout/2020
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Text is not wrapped around div with replaced content in layout_2020
5 participants
@ferjm @bors-servo @SimonSapin @jdm @highfive
You can’t perform that action at this time.