Remove syn 0.15 from our crate graph #25863

nox · 2020-02-28T13:05:14Z

No description provided.

highfive · 2020-02-28T13:05:20Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/htmlcanvaselement.rs, components/script/dom/htmlmediaelement.rs, components/script/Cargo.toml, components/webdriver_server/lib.rs, components/webdriver_server/Cargo.toml
@jgraham: components/webdriver_server/lib.rs, components/webdriver_server/Cargo.toml
@KiChjang: components/net/image_cache.rs, components/script/dom/htmlcanvaselement.rs, components/script/dom/htmlmediaelement.rs, components/script/Cargo.toml, components/net_traits/image/base.rs and 1 more
@emilio: components/layout/display_list/items.rs, components/layout/display_list/webrender_helpers.rs, components/style/Cargo.toml

highfive · 2020-02-28T13:05:22Z

Warning

These commits modify net, layout, style, and script code, but no tests are modified. Please consider adding a test!

nox · 2020-02-28T13:05:27Z

@bors-servo try=wpt


        Auto merge of #25863 - servo:synup, r=<try>

Remove syn 0.15 from our crate graph

bors-servo · 2020-02-28T13:05:33Z

⌛ Trying commit 7210962 with merge 841dbf5...

bors-servo · 2020-02-28T13:48:58Z

💔 Test failed - status-taskcluster

nox · 2020-03-02T09:10:36Z

Can't reproduce the failure locally.

r? @jdm

nox · 2020-03-02T14:21:11Z

@bors-servo r=jdm

bors-servo · 2020-03-02T14:21:12Z

📌 Commit 7579e9e has been approved by jdm

bors-servo · 2020-03-02T14:28:24Z

⌛ Testing commit 7579e9e with merge 4d179a2...


        Auto merge of #25863 - servo:synup, r=jdm

Remove syn 0.15 from our crate graph

bors-servo · 2020-03-02T14:54:22Z

💔 Test failed - status-taskcluster

jdm · 2020-03-02T15:05:18Z

error[E0599]: no method named `print_display_list` found for struct `webrender_api::display_list::DisplayListBuilder` in the current scope
    --> components/layout_thread_2020/lib.rs:1423:29
     |
1423 |             display_list.wr.print_display_list();
     |                             ^^^^^^^^^^^^^^^^^^ help: there is a method with a similar name: `emit_display_list`
error: aborting due to previous error

nox · 2020-03-02T16:35:25Z

Oopsie.

@bors-servo r=jdm

bors-servo · 2020-03-02T16:35:26Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: #25878

bors-servo · 2020-03-02T16:35:28Z

📌 Commit 5391e97 has been approved by jdm

nox · 2020-03-05T12:15:43Z

I think I properly fixed the expectations this time.

@bors-servo r=jdm

bors-servo · 2020-03-05T12:15:44Z

📌 Commit 9996e48 has been approved by jdm

bors-servo · 2020-03-05T12:15:49Z

⌛ Testing commit 9996e48 with merge 47d538c...


        Auto merge of #25863 - servo:synup, r=jdm

Remove syn 0.15 from our crate graph

bors-servo · 2020-03-05T13:02:50Z

💔 Test failed - status-taskcluster

jdm · 2020-03-05T13:08:49Z

@bors-servo retry

#21067 #25513

bors-servo · 2020-03-05T13:20:02Z

⌛ Testing commit 9996e48 with merge 79e2691...


        Auto merge of #25863 - servo:synup, r=jdm

Remove syn 0.15 from our crate graph

bors-servo · 2020-03-05T13:44:06Z

💔 Test failed - status-taskcluster

CYBAI · 2020-03-05T13:59:06Z

Linux tidy failed at building mozjs_sys 👀

�[0m�[0m�[1m�[31merror�[0m�[1m:�[0m failed to run custom build command for `mozjs_sys v0.67.1 (https://github.com/servo/mozjs?rev=59065889ec7726b767d70b8702b43b4e4776cbfe#59065889)`

Caused by:
  process didn't exit successfully: `/repo/target/debug/build/mozjs_sys-09a4190b192df570/build-script-build` (exit code: 101)
--- stdout
cargo:rerun-if-env-changed=MAKE
cargo:rerun-if-env-changed=MOZTOOLS_PATH
[[ /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/5906588/mozjs/js/src/configure -ot /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/5906588/mozjs/js/src/configure.in ]] && touch /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/5906588/mozjs/js/src/configure || true
[[ /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/5906588/mozjs/js/src/old-configure -ot /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/5906588/mozjs/js/src/old-configure.in ]] && touch /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/5906588/mozjs/js/src/old-configure || true
! [[ /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/5906588/mozjs/js/src/configure.in -ot /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/5906588/mozjs/js/src/configure ]] && touch /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/5906588/mozjs/js/src/configure || true
! [[ /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/5906588/mozjs/js/src/old-configure.in -ot /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/5906588/mozjs/js/src/old-configure ]] && touch /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/5906588/mozjs/js/src/old-configure || true
if [[ /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/5906588/mozjs/js/src/configure -nt /repo/target/debug/build/mozjs_sys-fac8652b6976d2aa/out/config.status ]] ; then \
  cd /repo/target/debug/build/mozjs_sys-fac8652b6976d2aa/out && \
  PYTHON="python2" MOZ_TOOLS="" \
  CC="clang" CFLAGS="" \
  CPP="gcc -E" CPPFLAGS="" \
  CXX="clang++" CXXFLAGS="" \
  AS="" AR="ar" \
  STLPORT_LIBS="" \
  RUST_TARGET="x86_64-unknown-linux-gnu" RUST_HOST="x86_64-unknown-linux-gnu" \
  RUST_SYSROOT="" \
  /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/5906588/mozjs/js/src/configure --disable-jemalloc --disable-js-shell --disable-tests --disable-shared-js --build-backends=RecursiveMake --enable-posix-nspr-emulation --with-ccache=sccache --disable-shared-js || (cat config.log && exit 1) ; \
fi
Creating Python environment
...
...
...
make[3]: *** [config/external/icu/i18n/target] Error 2
make[2]: *** [compile] Error 2
make[1]: *** [default] Error 2
make: *** [all] Error 2
thread 'main' panicked at 'assertion failed: result.success()', /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/5906588/build.rs:133:5
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.44/src/backtrace/libunwind.rs:86
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.44/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print_fmt
             at src/libstd/sys_common/backtrace.rs:78
   3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
             at src/libstd/sys_common/backtrace.rs:59
   4: core::fmt::write
             at src/libcore/fmt/mod.rs:1053
   5: std::io::Write::write_fmt
             at src/libstd/io/mod.rs:1428
   6: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:62
   7: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:49
   8: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:204
   9: std::panicking::default_hook
             at src/libstd/panicking.rs:224
  10: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:470
  11: std::panicking::begin_panic
             at /rustc/4ad62488258972bdb0e2df225d100f99ef58dbad/src/libstd/panicking.rs:397
  12: build_script_build::build_jsapi
             at ./build.rs:133
  13: build_script_build::main
             at ./build.rs:19
  14: std::rt::lang_start::{{closure}}
             at /rustc/4ad62488258972bdb0e2df225d100f99ef58dbad/src/libstd/rt.rs:67
  15: std::rt::lang_start_internal::{{closure}}
             at src/libstd/rt.rs:52
  16: std::panicking::try::do_call
             at src/libstd/panicking.rs:303
  17: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:86
  18: std::panicking::try
             at src/libstd/panicking.rs:281
  19: std::panic::catch_unwind
             at src/libstd/panic.rs:394
  20: std::rt::lang_start_internal
             at src/libstd/rt.rs:51
  21: std::rt::lang_start
             at /rustc/4ad62488258972bdb0e2df225d100f99ef58dbad/src/libstd/rt.rs:67
  22: main
  23: __libc_start_main
  24: _start
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

nox · 2020-03-05T15:03:45Z

This is definitely some intermittent failure. @bors-servo retry

bors-servo · 2020-03-05T15:03:51Z

⌛ Testing commit 9996e48 with merge 813be91...

jdm · 2020-03-05T15:13:04Z

For future reference, looking further up in the log for wintzimpl.o yields:

sccache: encountered fatal error
sccache: error : Invalid checksum
sccache:  cause: Invalid checksum
make[4]: *** [wintzimpl.o] Error 254

which is #25237.

bors-servo · 2020-03-05T16:03:33Z

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 813be91 to master...

highfive assigned paulrouget Feb 28, 2020

highfive added the S-awaiting-review label Feb 28, 2020

highfive added the S-tests-failed label Feb 28, 2020

nox force-pushed the synup branch from 7210962 to cdba321 Mar 2, 2020

highfive removed the S-tests-failed label Mar 2, 2020

highfive assigned jdm and unassigned paulrouget Mar 2, 2020

jdm approved these changes Mar 2, 2020

View changes

nox force-pushed the synup branch from cdba321 to 7579e9e Mar 2, 2020

highfive added S-awaiting-merge and removed S-awaiting-review labels Mar 2, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Mar 2, 2020

nox force-pushed the synup branch from 7579e9e to 5391e97 Mar 2, 2020

highfive added S-awaiting-merge and removed S-awaiting-review labels Mar 5, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Mar 5, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Mar 5, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Mar 5, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Mar 5, 2020

bors-servo merged commit 813be91 into master Mar 5, 2020
2 checks passed

2 checks passed

Community-TC (pull_request) TaskGroup: success
Details

homu Test successful
Details

bors-servo deleted the synup branch Mar 5, 2020

highfive removed the S-awaiting-merge label Mar 5, 2020

This was referenced Mar 5, 2020

Remove GL->d3d blit in HoloLens immersive mode #25855

Merged

Update SpiderMonkey #25678

Merged

servo / servo

Remove syn 0.15 from our crate graph #25863

Remove syn 0.15 from our crate graph #25863

nox commented Feb 28, 2020

highfive commented Feb 28, 2020

highfive commented Feb 28, 2020

nox commented Feb 28, 2020

bors-servo commented Feb 28, 2020

bors-servo commented Feb 28, 2020

nox commented Mar 2, 2020

nox commented Mar 2, 2020

bors-servo commented Mar 2, 2020

bors-servo commented Mar 2, 2020

bors-servo commented Mar 2, 2020

jdm commented Mar 2, 2020

nox commented Mar 2, 2020

bors-servo commented Mar 2, 2020

bors-servo commented Mar 2, 2020

nox commented Mar 5, 2020

bors-servo commented Mar 5, 2020

bors-servo commented Mar 5, 2020

bors-servo commented Mar 5, 2020

jdm commented Mar 5, 2020

bors-servo commented Mar 5, 2020

bors-servo commented Mar 5, 2020

CYBAI commented Mar 5, 2020

nox commented Mar 5, 2020

bors-servo commented Mar 5, 2020

jdm commented Mar 5, 2020

bors-servo commented Mar 5, 2020

servo / servo

Join GitHub today

Remove syn 0.15 from our crate graph #25863

Remove syn 0.15 from our crate graph #25863

Conversation

nox commented Feb 28, 2020

highfive commented Feb 28, 2020

highfive commented Feb 28, 2020

nox commented Feb 28, 2020

bors-servo commented Feb 28, 2020

bors-servo commented Feb 28, 2020

nox commented Mar 2, 2020

nox commented Mar 2, 2020

bors-servo commented Mar 2, 2020

bors-servo commented Mar 2, 2020

bors-servo commented Mar 2, 2020

jdm commented Mar 2, 2020

nox commented Mar 2, 2020

bors-servo commented Mar 2, 2020

bors-servo commented Mar 2, 2020

nox commented Mar 5, 2020

bors-servo commented Mar 5, 2020

bors-servo commented Mar 5, 2020

bors-servo commented Mar 5, 2020

jdm commented Mar 5, 2020

bors-servo commented Mar 5, 2020

bors-servo commented Mar 5, 2020

CYBAI commented Mar 5, 2020

nox commented Mar 5, 2020

bors-servo commented Mar 5, 2020

jdm commented Mar 5, 2020

bors-servo commented Mar 5, 2020