Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRename AbsolutelyPositionedBox::layout to AbsolutelyPositionedBox::to_hoisted #25864
+3
−3
Conversation
…_hoisted This method doesn't actually do any layout, but converts this block to a HoistedAbsolutelyPositionedBox which is hoisted and then laid-out with its containing block later. This makes the code a little easier to read.
mrobinson
changed the title
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 28, 2020
Rename AbsolutelyPositionedBox::layout to AbsolutelyPositionedBox::to_hoisted This method doesn't actually do any layout, but converts this block to a HoistedAbsolutelyPositionedBox which is hoisted and then laid-out with its containing block later. This makes the code a little easier to read. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it does not change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedFeb 28, 2020
•
edited
This method doesn't actually do any layout, but converts this block to a
HoistedAbsolutelyPositionedBox which is hoisted and then laid-out with
its containing block later. This makes the code a little easier to read.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors