Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AbsolutelyPositionedBox::layout to AbsolutelyPositionedBox::to_hoisted #25864

Merged
merged 1 commit into from Feb 28, 2020
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Rename AbsolutelyPositionedBox::layout to AbsolutelyPositionedBox::to…

…_hoisted

This method doesn't actually do any layout, but converts this block to a
HoistedAbsolutelyPositionedBox which is hoisted and then laid-out with
its containing block later. This makes the code a little easier to read.
  • Loading branch information
mrobinson committed Feb 28, 2020
commit c20c4688147927124160c61befc1362d9e7612e5
@@ -255,7 +255,7 @@ impl InlineFormattingContext {
},
};
ifc.positioning_context
.push(box_.layout(initial_start_corner, tree_rank));
.push(box_.to_hoisted(initial_start_corner, tree_rank));
},
InlineLevelBox::OutOfFlowFloatBox(_box_) => {
// TODO
@@ -320,7 +320,7 @@ impl BlockLevelBox {
))
},
BlockLevelBox::OutOfFlowAbsolutelyPositionedBox(box_) => {
positioning_context.push(box_.layout(Vec2::zero(), tree_rank));
positioning_context.push(box_.to_hoisted(Vec2::zero(), tree_rank));
Fragment::Anonymous(AnonymousFragment::no_op(
containing_block.style.writing_mode,
))
@@ -86,7 +86,7 @@ impl AbsolutelyPositionedBox {
}
}

pub(crate) fn layout(
pub(crate) fn to_hoisted(
&self,
initial_start_corner: Vec2<Length>,
tree_rank: usize,
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.