Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate ::before and ::after content from url() for layout2020 #25866

Merged
merged 1 commit into from Feb 28, 2020

Conversation

@ferjm
Copy link
Member

ferjm commented Feb 28, 2020

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes
@highfive
Copy link

highfive commented Feb 28, 2020

Heads up! This PR modifies the following files:

  • @emilio: components/style/values/specified/counters.rs
@ferjm
Copy link
Member Author

ferjm commented Feb 28, 2020

@highfive highfive assigned SimonSapin and unassigned asajeffrey Feb 28, 2020
@nox
Copy link
Member

nox commented Feb 28, 2020

Nice.

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2020

📌 Commit dc9a33f has been approved by nox

@highfive highfive assigned nox and unassigned SimonSapin Feb 28, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2020

Testing commit dc9a33f with merge 239838d...

bors-servo added a commit that referenced this pull request Feb 28, 2020
Generate ::before and ::after content from url() for layout2020

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Feb 28, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2020

Testing commit dc9a33f with merge 09321a1...

bors-servo added a commit that referenced this pull request Feb 28, 2020
Generate ::before and ::after content from url() for layout2020

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Feb 28, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2020

Testing commit dc9a33f with merge 44d8727...

@bors-servo
Copy link
Contributor

bors-servo commented Feb 28, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 44d8727 to master...

@bors-servo bors-servo merged commit 44d8727 into servo:master Feb 28, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@ferjm ferjm deleted the ferjm:url.generated.content branch Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.