Implement readablestream support #25873

gterzian · 2020-02-29T05:35:39Z

FIX #21482
FIX #24876
FIX #26392

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #___ (GitHub issue number if applicable)

There are tests for these changes OR
These changes do not require tests because ___

highfive · 2020-02-29T05:35:45Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/interface.rs
@jgraham: tests/wpt/include.ini
@KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/interface.rs

gterzian · 2020-03-15T07:20:36Z

@jdm Ok so this actually works now...

I still need to look at the net unit-tests, of which I think a few might be broken, but at the WPT level it's looking pretty good.

I squashed everything into one commit, sorry. The thing is that this grew quite organically and I didn't always knew what I was about to do in advance, so the various commits ended-up overlapping concerns.

It might actually make sense to review all in one go, since the various integration points use the various API's of the stream(which is why stuff grew organically as I added more integration, and then realized I need to change the API and add more integration or else break half of fetch...).

There are essentially five integrations:

One with Request.
One with Response.
One with "consuming bodies"(both for responses and requests).
One for "transmitting bodies", which is only about requests.
One with getting a stream for a Blob.

This also depends on servo/rust-mozjs#495

gterzian · 2020-03-15T11:43:12Z

Ok this breaks the request in devtools, however it doesn't look that hard to integrate that too. Now that is something I will do in a separate commit...

bors-servo · 2020-03-16T03:09:45Z

☔ The latest upstream changes (presumably #25966) made this pull request unmergeable. Please resolve the merge conflicts.

gterzian · 2020-05-31T16:35:11Z

@jdm r?

jdm

Looks good! Thanks for sticking with this!

jdm · 2020-06-03T20:36:02Z

components/script/body.rs

+    Null,
+    /// Another Dom object as source,
+    /// TODO: store the actual object
+    /// and re-exctact a stream on re-direct.


Please file an issue for this if there isn't one already.

Yes that would be #26686


        integrate readablestream with fetch and blob


        require entered realm, use aes, to append native promise handler


        net: don't set content-length in obtain response


        net: update list of bad ports


        net: use an empty body for the null body case


        bypass SM for in-memory streams in request bodies, dis-allow other ca…

…ses in sync XHR


        partially integrate streaming request bodies with http re-direct

gterzian · 2020-06-04T07:03:56Z

@bors-servo r=jdm

@jdm thanks for the review(s)!

bors-servo · 2020-06-04T07:03:57Z

📌 Commit c1b7653 has been approved by jdm

bors-servo · 2020-06-04T07:04:03Z

⌛ Testing commit c1b7653 with merge 8536cee...

bors-servo · 2020-06-04T08:03:28Z

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 8536cee to master...

highfive assigned jdm Feb 29, 2020

highfive added the S-awaiting-review label Feb 29, 2020

gterzian force-pushed the gterzian:implement_readablestream_support branch 5 times, most recently from 93bfe8c to c6b6544 Feb 29, 2020

This was referenced Mar 3, 2020

Add glue for readablestream external underlying source servo/rust-mozjs#495

Merged

Implement ReadableStream support #21482

Closed

gterzian force-pushed the gterzian:implement_readablestream_support branch 7 times, most recently from 7ab2dc8 to a54c975 Mar 5, 2020

gterzian force-pushed the gterzian:implement_readablestream_support branch 4 times, most recently from 33a9a66 to a9f1ee2 Mar 13, 2020

gterzian force-pushed the gterzian:implement_readablestream_support branch 4 times, most recently from bbc6812 to 3a2c24b Mar 15, 2020

highfive added the S-needs-rebase label Mar 16, 2020

gterzian force-pushed the gterzian:implement_readablestream_support branch from 203426a to c395234 Mar 18, 2020

gterzian removed the S-needs-rebase label May 31, 2020

This was referenced May 31, 2020

ReadableStream and in-parallel/event-loop integration question whatwg/fetch#976

Closed

Integrate HTTP network stack, including the HTTP cache, with streams #26743

Open

jdm approved these changes Jun 3, 2020

View changes

jdm added S-awaiting-answer and removed S-awaiting-review labels Jun 3, 2020

gterzian added 7 commits Feb 29, 2020

integrate readablestream with fetch and blob

bd5796c

require entered realm, use aes, to append native promise handler

48d4aec

net: don't set content-length in obtain response

ca68631

net: update list of bad ports

7d51997

net: use an empty body for the null body case

3535dd7

bypass SM for in-memory streams in request bodies, dis-allow other ca…

ad4dea7

…ses in sync XHR

partially integrate streaming request bodies with http re-direct

Loading status checks…

c1b7653

gterzian force-pushed the gterzian:implement_readablestream_support branch from f3c70f1 to c1b7653 Jun 4, 2020

highfive added the S-awaiting-review label Jun 4, 2020

highfive added S-awaiting-merge and removed S-awaiting-review S-awaiting-answer labels Jun 4, 2020

bors-servo merged commit 8536cee into servo:master Jun 4, 2020
2 checks passed

2 checks passed

Community-TC (pull_request) TaskGroup: success
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jun 4, 2020

gterzian deleted the gterzian:implement_readablestream_support branch Jun 4, 2020

bors-servo mentioned this pull request Jun 4, 2020

Move away from Promise.all way and check if we need to finish manually #26395

Merged

4 of 4 tasks complete

This was referenced Jun 13, 2020

Make streaming upload work. #26904

Closed

Investigage full-duplex request/response streaming #26905

Open

servo / servo

Implement readablestream support #25873

Implement readablestream support #25873

gterzian commented Feb 29, 2020 •

edited

highfive commented Feb 29, 2020

gterzian commented Mar 15, 2020

gterzian commented Mar 15, 2020

bors-servo commented Mar 16, 2020

gterzian commented May 31, 2020

jdm left a comment

This comment has been minimized.

This comment has been minimized.

gterzian commented Jun 4, 2020

bors-servo commented Jun 4, 2020

bors-servo commented Jun 4, 2020

bors-servo commented Jun 4, 2020

servo / servo

Join GitHub today

Implement readablestream support #25873

Implement readablestream support #25873

Conversation

gterzian commented Feb 29, 2020 • edited

highfive commented Feb 29, 2020

gterzian commented Mar 15, 2020

gterzian commented Mar 15, 2020

bors-servo commented Mar 16, 2020

gterzian commented May 31, 2020

jdm left a comment

This comment has been minimized.

jdm Jun 3, 2020

This comment has been minimized.

gterzian Jun 4, 2020

gterzian commented Jun 4, 2020

bors-servo commented Jun 4, 2020

bors-servo commented Jun 4, 2020

bors-servo commented Jun 4, 2020

gterzian commented Feb 29, 2020 •

edited