Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade mime crate to use the essence function #25876
Merged
+16
−12
Conversation
highfive
commented
Mar 2, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Mar 2, 2020
|
|
|
r? @Manishearth |
|
@bors-servo r+ thanks! |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 2, 2020
Upgrade mime crate to use the essence function While implementing module script, the `essence` function is not supported in mime crate yet so Manish filed the issue. So, as that issue is fixed and shipped, we can upgrade mime crate to use the `essence_str` function. I've tried to run https://threejs.org/examples/webgl_animation_cloth.html locally. Other than a bunch of `Unimplemented canvas2d.fillText`, I can see the animated cloth. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
CYBAI commentedMar 2, 2020
While implementing module script, the
essencefunction is not supported in mime crate yet so Manish filed the issue.So, as that issue is fixed and shipped, we can upgrade mime crate to use the
essence_strfunction.I've tried to run https://threejs.org/examples/webgl_animation_cloth.html locally. Other than a bunch of
Unimplemented canvas2d.fillText, I can see the animated cloth../mach build -ddoes not report any errors./mach test-tidydoes not report any errors