Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Android CI builds #25877

Merged
merged 1 commit into from Mar 2, 2020
Merged

Disable Android CI builds #25877

merged 1 commit into from Mar 2, 2020

Conversation

@nox
Copy link
Member

nox commented Mar 2, 2020

No description provided.

@nox
Disable Android CI builds
Loading status checks…
74aca07
@nox
Copy link
Member Author

nox commented Mar 2, 2020

r? @jdm
@highfive highfive assigned jdm and unassigned Manishearth Mar 2, 2020
@jdm
Copy link
Member

jdm commented Mar 2, 2020

@bors-servo r+
So long, Android!
@bors-servo
Copy link
Contributor

bors-servo commented Mar 2, 2020

📌 Commit 74aca07 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Mar 2, 2020

⌛ Testing commit 74aca07 with merge 3f5a4c8...
bors-servo added a commit that referenced this pull request Mar 2, 2020
@bors-servo
Auto merge of #25877 - servo:byebye-android, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3f5a4c8 
Disable Android CI builds
@bors-servo
Copy link
Contributor

bors-servo commented Mar 2, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Mar 2, 2020

This PR only removes the android CI builds so I believe this is an intermittent.
But, I'm not sure if there's an existing one for it 👀?

  ▶ FAIL [expected PASS] /css/CSS2/positioning/left-056.xht
  │   → /css/CSS2/positioning/left-056.xht 0b7dd821d6234d26c19bbf09815a358695c6f015
  └   → /css/CSS2/reference/ref-black-96px-square-no-red.xht 2d20aca73fe80e40c4fdf131b58467f209c0a571
@jdm
Copy link
Member

jdm commented Mar 2, 2020

Looking at the test-wpt.log in https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer-structured.xhtml shows that it's #23290.
@jdm
Copy link
Member

jdm commented Mar 2, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 2, 2020

⌛ Testing commit 74aca07 with merge 3cbbb2b...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 2, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 3cbbb2b to master...
@bors-servo bors-servo merged commit 3cbbb2b into master Mar 2, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the byebye-android branch Mar 2, 2020
@Darkspirit
Copy link
Contributor

Darkspirit commented Mar 3, 2020

In the future this could be revived by #23691.
@jdm
Copy link
Member

jdm commented Mar 3, 2020

More importantly, reviving it will require:

  • Upgrading the NDK to v20
  • Writing surfman integration code that we're not bothering to write in #25853
@Darkspirit
Copy link
Contributor

Darkspirit commented Mar 3, 2020 •
edited

Firefox 71 has NDK 20 patches: bug 1577220 (Upgrade from NDK 17b to 20)
@Darkspirit Darkspirit mentioned this pull request Apr 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@nox @jdm @bors-servo @CYBAI @Darkspirit @Manishearth @highfive
You can’t perform that action at this time.