Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3/4 nightly rustc. #25898

Merged
merged 1 commit into from Mar 4, 2020
Merged

Update to 3/4 nightly rustc. #25898

merged 1 commit into from Mar 4, 2020

Conversation

@jdm
Copy link
Member

jdm commented Mar 4, 2020

The comment changes address a bunch of new warnings that look like this:

warning: unused doc comment
   --> components/script/dom/rtcpeerconnection.rs:449:5
    |
449 |     /// https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-signalingstatechange
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macros
    |
    = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion
@jdm
Update to 3/4 nightly rustc.
Loading status checks…
bf7537e
@highfive
Copy link

highfive commented Mar 4, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/rtcpeerconnection.rs, components/script/dom/messageport.rs, components/script/dom/broadcastchannel.rs, components/script/dom/baseaudiocontext.rs, components/script/dom/xrsession.rs
  • @KiChjang: components/script/dom/rtcpeerconnection.rs, components/script/dom/messageport.rs, components/script/dom/broadcastchannel.rs, components/script/dom/baseaudiocontext.rs, components/script/dom/xrsession.rs
@highfive
Copy link

highfive commented Mar 4, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member Author

jdm commented Mar 4, 2020

r? @asajeffrey
@highfive highfive assigned asajeffrey and unassigned paulrouget Mar 4, 2020
@asajeffrey
Copy link
Member

asajeffrey commented Mar 4, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2020

📌 Commit bf7537e has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2020

⌛ Testing commit bf7537e with merge 521f2bd...
bors-servo added a commit that referenced this pull request Mar 4, 2020
@bors-servo
Auto merge of #25898 - jdm:rustup, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
521f2bd 
Update to 3/4 nightly rustc.

The comment changes address a bunch of new warnings that look like this:
```
warning: unused doc comment
   --> components/script/dom/rtcpeerconnection.rs:449:5
    |
449 |     /// https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-signalingstatechange
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macros
    |
    = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion
```
@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Mar 4, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2020

⌛ Testing commit bf7537e with merge ea8aed1...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2020

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing ea8aed1 to master...
@bors-servo bors-servo merged commit ea8aed1 into servo:master Mar 4, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
jdm added a commit to jdm/servo that referenced this pull request Mar 6, 2020
@jdm
Revert "Auto merge of servo#25898 - jdm:rustup, r=asajeffrey"
a29f4a9 
This reverts commit ea8aed1, reversing
changes made to 3749eb5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @asajeffrey @bors-servo @paulrouget
You can’t perform that action at this time.