Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the WebGL2 framebuffer render validation #25903

Merged
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Improved the WebGL2 framebuffer render validation

It seems `MissingColorAttachment` should be returned only when
all of the color attachments are missing.
  • Loading branch information
mmatyas committed Mar 5, 2020
commit 5cb6eb274450b1418dab9e417fe4a58edc09b7f1
@@ -468,7 +468,7 @@ impl WebGLFramebuffer {
return CompleteForRendering::Complete;
}

if self.colors.iter().any(|att| att.borrow().is_none()) {
if self.colors.iter().all(|att| att.borrow().is_none()) {
return CompleteForRendering::MissingColorAttachment;
}

This file was deleted.

@@ -8,24 +8,9 @@
[WebGL test #8: getError expected: NO_ERROR. Was INVALID_ENUM : Setup framebuffer with texture should succeed.]
expected: FAIL

[WebGL test #3: getError expected: NO_ERROR. Was INVALID_OPERATION : Clearing the texture level 0 to green should succeed.]
expected: FAIL

[WebGL test #9: getError expected: NO_ERROR. Was INVALID_OPERATION : Clearing the texture level 2 to green should succeed.]
expected: FAIL

[WebGL test #6: getError expected: NO_ERROR. Was INVALID_OPERATION : Clearing the texture level 1 to green should succeed.]
expected: FAIL

[WebGL test #14: should be green\nat (0, 0) expected: 0,255,0,255 was 0,0,0,0]
expected: FAIL

[WebGL test #13: getError expected: NO_ERROR. Was INVALID_ENUM : Drawing the texture to default framebuffer with base level 0 should succeed.]
expected: FAIL

[WebGL test #2: getError expected: NO_ERROR. Was INVALID_ENUM : Setup framebuffer with texture should succeed.]
expected: FAIL

[WebGL test #12: getError expected: NO_ERROR. Was INVALID_OPERATION : Clearing the texture level 3 to green should succeed.]
expected: FAIL

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.