Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for some more WebGL2 renderbuffer functions #25904
Merged
+255
−70
Conversation
highfive
commented
Mar 5, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Mar 5, 2020
|
|
mmatyas
force-pushed the
mmatyas:webgl_fns_framebuf_renderbuf
branch
from
25acfcc
to
807b5d9
|
Good start! |
components/canvas/webgl_thread.rs
Outdated
| target, | ||
| internal_format, | ||
| param, | ||
| max_count, |
This comment has been minimized.
This comment has been minimized.
jdm
Mar 5, 2020
Member
Rather than having the caller pass the size of the parameter array, we should match on the param and calculate how large the array should be.
Additionally, rather than having the script thread send two commands to retrieve the sample count followed by the samples, we should transparently get the number of required samples when handling the request for samples.
| @@ -221,24 +223,46 @@ impl WebGLRenderbuffer { | |||
| _ => return Err(WebGLError::InvalidEnum), | |||
| }; | |||
|
|
|||
| let (sender, receiver) = webgl_channel().unwrap(); | |||
This comment has been minimized.
This comment has been minimized.
| .send_command(WebGLCommand::GetInternalFormativ( | ||
| constants::RENDERBUFFER, | ||
| internal_format, | ||
| InternalFormatInt::Samples, |
This comment has been minimized.
This comment has been minimized.
mmatyas
force-pushed the
mmatyas:webgl_fns_framebuf_renderbuf
branch
from
807b5d9
to
b8ac3e7
|
Thanks! Updated the code, but then I ran into #25908 so couldn't check if it affects the tests yet. |
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Mar 6, 2020
Add support for some more WebGL2 renderbuffer functions Adds support for the following WebGL2 calls: - `RenderbufferStorageMultisample` - `GetInternalFormativ` See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.5 <!-- Please describe your changes on the following line: --> The test results depend on #25903. cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
There are also different |
|
|
mmatyas
force-pushed the
mmatyas:webgl_fns_framebuf_renderbuf
branch
from
b8ac3e7
to
ad7a97e
|
Rebased and run the tests again. I don't encounter crashes locally, hopefully the CI will now pass too. |
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Mar 9, 2020
Add support for some more WebGL2 renderbuffer functions Adds support for the following WebGL2 calls: - `RenderbufferStorageMultisample` - `GetInternalFormativ` See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.5 <!-- Please describe your changes on the following line: --> The test results depend on #25903. cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
jdm
force-pushed the
mmatyas:webgl_fns_framebuf_renderbuf
branch
from
b6aa8c4
to
6cdbab5
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 13, 2020
Add support for some more WebGL2 renderbuffer functions Adds support for the following WebGL2 calls: - `RenderbufferStorageMultisample` - `GetInternalFormativ` See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.5 <!-- Please describe your changes on the following line: --> The test results depend on #25903. cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Mar 13, 2020
Add support for some more WebGL2 renderbuffer functions Adds support for the following WebGL2 calls: - `RenderbufferStorageMultisample` - `GetInternalFormativ` See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.5 <!-- Please describe your changes on the following line: --> The test results depend on #25903. cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mmatyas commentedMar 5, 2020
Adds support for the following WebGL2 calls:
RenderbufferStorageMultisampleGetInternalFormativSee: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.5
The test results depend on #25903.
cc @jdm @zakorgy
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors