Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 3/4 nightly rustc upgrade #25911

Merged
merged 1 commit into from Mar 6, 2020
Merged

Revert 3/4 nightly rustc upgrade #25911

merged 1 commit into from Mar 6, 2020

Conversation

@jdm
Copy link
Member

jdm commented Mar 6, 2020

Fixes #25908.
@jdm
Revert "Auto merge of #25898 - jdm:rustup, r=asajeffrey"
Loading status checks…
a29f4a9 
This reverts commit ea8aed1, reversing
changes made to 3749eb5.
@highfive
Copy link

highfive commented Mar 6, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/rtcpeerconnection.rs, components/script/dom/messageport.rs, components/script/dom/broadcastchannel.rs, components/script/dom/baseaudiocontext.rs, components/script/dom/xrsession.rs
  • @KiChjang: components/script/dom/rtcpeerconnection.rs, components/script/dom/messageport.rs, components/script/dom/broadcastchannel.rs, components/script/dom/baseaudiocontext.rs, components/script/dom/xrsession.rs
@highfive
Copy link

highfive commented Mar 6, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member Author

jdm commented Mar 6, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

📌 Commit a29f4a9 has been approved by jdm
@highfive highfive assigned jdm and unassigned Manishearth Mar 6, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

⌛ Testing commit a29f4a9 with merge 5f095f7...
bors-servo added a commit that referenced this pull request Mar 6, 2020
@bors-servo
Auto merge of #25911 - jdm:rustup-revert, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5f095f7 
Revert 3/4 nightly rustc upgrade

Fixes #25908.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

💔 Test failed - status-taskcluster
@Manishearth
Manishearth approved these changes Mar 6, 2020
View changes
@jdm
Copy link
Member Author

jdm commented Mar 6, 2020

@bors-servo retry
@jdm
Copy link
Member Author

jdm commented Mar 6, 2020

@bors-servo p=10
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

⌛ Testing commit a29f4a9 with merge 3652769...
bors-servo added a commit that referenced this pull request Mar 6, 2020
@bors-servo
Auto merge of #25911 - jdm:rustup-revert, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3652769 
Revert 3/4 nightly rustc upgrade

Fixes #25908.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Mar 6, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

⌛ Testing commit a29f4a9 with merge b062f51...
@highfive highfive removed the S-tests-failed label Mar 6, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing b062f51 to master...
@bors-servo bors-servo merged commit b062f51 into servo:master Mar 6, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

3/4 rustc upgrade broke RootedTraceableSet with RootedVec
4 participants
@jdm @highfive @bors-servo @Manishearth
You can’t perform that action at this time.