Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render HTML <canvas> elements on layout 2020 #25916

Merged
merged 2 commits into from Mar 6, 2020
Merged

Render HTML <canvas> elements on layout 2020 #25916

merged 2 commits into from Mar 6, 2020

Conversation

@ferjm
Copy link
Member

ferjm commented Mar 6, 2020

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #25885
  • There are tests for these changes
@ferjm
Enable 2dcontext tests for layout 2020
0bd794a
@highfive
Copy link

highfive commented Mar 6, 2020

Heads up! This PR modifies the following files:

  • @jgraham: tests/wpt/include-layout-2020.ini
@ferjm
Copy link
Member Author

ferjm commented Mar 6, 2020

@bors-servo try=wpt-2020
bors-servo added a commit that referenced this pull request Mar 6, 2020
@bors-servo
Auto merge of #25916 - ferjm:canvas.layout.2020, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3c767f9 
Render HTML <canvas> elements on layout 2020

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25885
- [X] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

⌛ Trying commit 5e3c499 with merge 3c767f9...
@ferjm
Copy link
Member Author

ferjm commented Mar 6, 2020

r? @nox
@highfive highfive assigned nox and unassigned Manishearth Mar 6, 2020
@ferjm ferjm added the A-layout/2020 label Mar 6, 2020
@nox
Copy link
Member

nox commented Mar 6, 2020

r=me but please squash the expectations update with the implementation commit.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@ferjm
Canvas rendering for layout 2020
Loading status checks…
f0e30f5 
Update test expectations with layout 2020 canvas support
@ferjm ferjm force-pushed the ferjm:canvas.layout.2020 branch from 5e3c499 to f0e30f5 Mar 6, 2020
@ferjm
Copy link
Member Author

ferjm commented Mar 6, 2020

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

📌 Commit f0e30f5 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

⌛ Testing commit f0e30f5 with merge 85ed7d3...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 85ed7d3 to master...
@bors-servo bors-servo merged commit 85ed7d3 into servo:master Mar 6, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@ferjm ferjm deleted the ferjm:canvas.layout.2020 branch Mar 6, 2020
@jdm jdm mentioned this pull request Mar 13, 2020
Merged
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
A-layout/2020
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Render HTML <canvas> elements
5 participants
@ferjm @highfive @bors-servo @nox @Manishearth
You can’t perform that action at this time.