Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compare vtable pointers anymore #25918

Merged
merged 2 commits into from Mar 6, 2020
Merged

Don't compare vtable pointers anymore #25918

merged 2 commits into from Mar 6, 2020

Conversation

@nox
Copy link
Member

nox commented Mar 6, 2020

No description provided.

nox added 2 commits Mar 6, 2020
@nox
Change how we reflect DOM objects in codegen
05077d3 
We now go through <Root<MaybeUnreflectedDom<T>>>::reflect_with,
to decrease the amount of bad stuff we can end up doing. This
avoids a source of vtable pointer instability that could cause
issues down the road.
@nox
Don't compare the vtable pointers anymore when unrooting stuff
Loading status checks…
b5aa83f
@highfive
Copy link

highfive commented Mar 6, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/root.rs, components/script/dom/bindings/trace.rs
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/root.rs, components/script/dom/bindings/trace.rs
@highfive
Copy link

highfive commented Mar 6, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox nox changed the title Vtable pointers are not comparable Don't compare vtable pointers anymore Mar 6, 2020
@nox
Copy link
Member Author

nox commented Mar 6, 2020

r? @jdm
@highfive highfive assigned jdm and unassigned paulrouget Mar 6, 2020
@nox
Copy link
Member Author

nox commented Mar 6, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

⌛ Trying commit b5aa83f with merge 1b10c14...
bors-servo added a commit that referenced this pull request Mar 6, 2020
@bors-servo
Auto merge of #25918 - servo:vtable-pointers-are-not-comparable, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1b10c14 
Don't compare vtable pointers anymore
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Mar 6, 2020

@bors-servo r+
Nice improvement!
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

📌 Commit b5aa83f has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

⌛ Testing commit b5aa83f with merge a0f14ce...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing a0f14ce to master...
@bors-servo bors-servo merged commit a0f14ce into master Mar 6, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the vtable-pointers-are-not-comparable branch Mar 6, 2020
@jdm jdm mentioned this pull request Mar 10, 2020
Merged
bors-servo added a commit that referenced this pull request Mar 10, 2020
@bors-servo
Auto merge of #25939 - jdm:rustup2, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a81f9ec 
Update to 3/4 nightly rustc.

Now that #25918 has merged, this should be safe to use.
bors-servo added a commit that referenced this pull request Mar 11, 2020
@bors-servo
Auto merge of #25939 - jdm:rustup2, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
58f3766 
Update to 3/4 nightly rustc.

Now that #25918 has merged, this should be safe to use.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @bors-servo @jdm @paulrouget
You can’t perform that action at this time.