Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compare vtable pointers anymore #25918

Merged
merged 2 commits into from Mar 6, 2020
Merged

Don't compare vtable pointers anymore #25918

merged 2 commits into from Mar 6, 2020
+32 −15

Commits on Mar 6, 2020

  1. Change how we reflect DOM objects in codegen 

    We now go through <Root<MaybeUnreflectedDom<T>>>::reflect_with,
to decrease the amount of bad stuff we can end up doing. This
avoids a source of vtable pointer instability that could cause
issues down the road.
    @nox
    nox committed Mar 6, 2020
    05077d3

  2. Don't compare the vtable pointers anymore when unrooting stuff

    @nox
    nox committed Mar 6, 2020
    Loading status checks…
    b5aa83f
You can’t perform that action at this time.