Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDownload usable macOS SDK during bootstrap #25920
Closed
Conversation
highfive
commented
Mar 6, 2020
|
Heads up! This PR modifies the following files:
|
|
Seems ok but I'm pretty concerned about this. |
| sdk_file = TARGET_MACOS_SDK + ".tar.xz" | ||
| archive_path = os.path.join(deps_dir, sdk_file) | ||
| print('Downloading SDK for macOS 10.14...') | ||
| sdk_url = "https://github.com/phracker/MacOSX-SDKs/releases/download/10.15/" + sdk_file |
This comment has been minimized.
This comment has been minimized.
nox
Mar 9, 2020
Member
I'm not in favour of downloading and installing things off a random GH account, tbh. Why can't those be installed from Apple stuff?
This comment has been minimized.
This comment has been minimized.
jdm
Mar 9, 2020
Author
Member
My assumption is that they're not available in a convenient place. Doesn't matter with your backport, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedMar 6, 2020
•
edited
This renames the
bootstrapmach command tobootstrap-buildbecause the bootstrap name is hardcoded into mach in a way that interferes with the actual command execution (#25224). These changes also support automatically setting up a 10.14 SDK on macOS 10.15, which is needed to build spidermonkey since #25678 merged.Depends on servo/mozjs#233.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors