Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VTTRegion and part of VTTCue DOM interfaces #25923

Merged
merged 3 commits into from Mar 9, 2020

Conversation

@iulianR
Copy link
Contributor

iulianR commented Mar 7, 2020

Hello! In this PR I implemented the VTTRegion DOM interface and part of VTTCue (#22312). Before continuing I thought it's maybe a good idea to first request a review or even merge what I did up to this point, as I might get stuck on the next part. I have a slight idea of what needs to be done (I assume it's hooking the GStreamer parser somewhere in GetCueAsHTML()), but a short outline or some more instructions would help a lot.

I updated test expectations by first running:

./mach test-wpt tests/wpt/web-platform-tests/webvtt/api --log-raw servo.log --pref dom.webvtt.enabled=true

then

./mach update-wpt servo.log

Thanks!

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented Mar 7, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/VTTCue.webidl, components/script/dom/vttregion.rs, components/script/dom/mod.rs, components/script/dom/texttrackcue.rs, components/script/dom/webidls/VTTRegion.webidl and 1 more
  • @KiChjang: components/script/dom/webidls/VTTCue.webidl, components/script/dom/vttregion.rs, components/script/dom/mod.rs, components/script/dom/texttrackcue.rs, components/script/dom/webidls/VTTRegion.webidl and 1 more
Copy link
Member

jdm left a comment

This base implementation looks good so far!

@jdm jdm assigned jdm and unassigned nox Mar 9, 2020
@jdm
Copy link
Member

jdm commented Mar 9, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2020

📌 Commit 7293cf1 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2020

Testing commit 7293cf1 with merge 95f3d46...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 95f3d46 to master...

@bors-servo bors-servo merged commit 95f3d46 into servo:master Mar 9, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Mar 9, 2020
2 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.