Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3/4 nightly rustc. #25939

Merged
merged 1 commit into from Mar 11, 2020
Merged

Update to 3/4 nightly rustc. #25939

merged 1 commit into from Mar 11, 2020

Conversation

@jdm
Copy link
Member

jdm commented Mar 10, 2020

Now that #25918 has merged, this should be safe to use.
@jdm
Update to 3/4 nightly rustc.
Loading status checks…
51145cf
@highfive
Copy link

highfive commented Mar 10, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/rtcpeerconnection.rs, components/script/dom/messageport.rs, components/script/dom/broadcastchannel.rs, components/script/dom/baseaudiocontext.rs, components/script/dom/xrsession.rs
  • @KiChjang: components/script/dom/rtcpeerconnection.rs, components/script/dom/messageport.rs, components/script/dom/broadcastchannel.rs, components/script/dom/baseaudiocontext.rs, components/script/dom/xrsession.rs
@highfive
Copy link

highfive commented Mar 10, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member Author

jdm commented Mar 10, 2020

r? @asajeffrey
@highfive highfive assigned asajeffrey and unassigned SimonSapin Mar 10, 2020
@asajeffrey
Copy link
Member

asajeffrey commented Mar 10, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 10, 2020

📌 Commit 51145cf has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Mar 10, 2020

⌛ Testing commit 51145cf with merge a81f9ec...
bors-servo added a commit that referenced this pull request Mar 10, 2020
@bors-servo
Auto merge of #25939 - jdm:rustup2, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a81f9ec 
Update to 3/4 nightly rustc.

Now that #25918 has merged, this should be safe to use.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 10, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Mar 10, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2020

⌛ Testing commit 51145cf with merge 58f3766...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2020

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing 58f3766 to master...
@bors-servo bors-servo merged commit 58f3766 into servo:master Mar 11, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @asajeffrey @bors-servo @SimonSapin
You can’t perform that action at this time.