Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the WebIDL parser #25964

Merged
merged 2 commits into from Mar 17, 2020
Merged

Update the WebIDL parser #25964

merged 2 commits into from Mar 17, 2020

Conversation

@nox
Copy link
Member

nox commented Mar 14, 2020

It now supports Python 3.
nox added 2 commits Mar 14, 2020
@nox
Update the WebIDL parser
4930479 
Upstream doesn't allow downloading .tar.gz archives so update.sh was changed
to use unzip.
@nox
Do not do weird scope things in MethodDefiner
Loading status checks…
3f30c7d 
Variable `m` comes from a previous list comprehension earlier in the
function is not actually properly defined.
@highfive
Copy link

highfive commented Mar 14, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/codegen/parser/tests/test_nullable_equivalency.py, components/script/dom/bindings/codegen/parser/tests/test_extended_attributes.py, components/script/dom/bindings/codegen/parser/ext-attribute-no-value-error.patch, components/script/dom/bindings/codegen/parser/tests/test_distinguishability.py and 6 more
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/codegen/parser/tests/test_nullable_equivalency.py, components/script/dom/bindings/codegen/parser/tests/test_extended_attributes.py, components/script/dom/bindings/codegen/parser/ext-attribute-no-value-error.patch, components/script/dom/bindings/codegen/parser/tests/test_distinguishability.py and 6 more
@CYBAI
Copy link
Collaborator

CYBAI commented Mar 16, 2020

Maybe this will fix #25955 👀?
@nox
Copy link
Member Author

nox commented Mar 16, 2020

It updates WebIDL.py but it doesn't make the script crate work with Python 3. And mozjs_sys and style also don't build with Python 3.
@jdm
jdm reviewed Mar 17, 2020
View changes
components/script/dom/bindings/codegen/CodegenRust.py Show resolved Hide resolved
@jdm jdm assigned jdm and unassigned SimonSapin Mar 17, 2020
@jdm
Copy link
Member

jdm commented Mar 17, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

⌛ Trying commit 3f30c7d with merge 33a6b3d...
bors-servo added a commit that referenced this pull request Mar 17, 2020
@bors-servo
Auto merge of #25964 - servo:webidl, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
33a6b3d 
Update the WebIDL parser

It now supports Python 3.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@jdm
Copy link
Member

jdm commented Mar 17, 2020

Not super confidence-boosting that fixing the scoping issue triggered no test result changes in idlharness tests. Oh well!
@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

📌 Commit 3f30c7d has been approved by jdm
@nox
Copy link
Member Author

nox commented Mar 17, 2020

Not super confidence-boosting that fixing the scoping issue triggered no test result changes in idlharness tests. Oh well!

AFAIK this block of code only uses object properties that are common to all descriptors of the interface for which we are generating stuff. To make it an actual bug, you need to do some different [Pref] attributes on different interface members and whatnot, with the last one getting different gates than the ones you want for the iterator symbols.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

⌛ Testing commit 3f30c7d with merge 82b0180...
bors-servo added a commit that referenced this pull request Mar 17, 2020
@bors-servo
Auto merge of #25964 - servo:webidl, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
82b0180 
Update the WebIDL parser

It now supports Python 3.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Mar 17, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

⌛ Testing commit 3f30c7d with merge 9fb83d8...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 9fb83d8 to master...
@bors-servo bors-servo merged commit 9fb83d8 into master Mar 17, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the webidl branch Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @CYBAI @jdm @bors-servo @SimonSapin
You can’t perform that action at this time.