Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use matrix for TC notifications. #25969

Closed
wants to merge 1 commit into from
Closed

Use matrix for TC notifications. #25969

wants to merge 1 commit into from

Conversation

@jdm
Copy link
Member

jdm commented Mar 16, 2020

No description provided.

@jdm
Copy link
Member Author

jdm commented Mar 19, 2020

@SimonSapin
Copy link
Member

SimonSapin commented Mar 19, 2020

Diff looks OK but it looks like the TC side of this is not fully set up yet: https://bugzilla.mozilla.org/show_bug.cgi?id=1618384 is still open and nothing happened in the channel when I tried https://community-tc.services.mozilla.com/tasks/fLlGZ_4DQO-e88Dh_Kl2xg/runs/0 manually.

Additionally I’d like to make this configurable so we can have different nicknames mentioned in the notifications for different tasks (CC #24889 (review))

And before landing we should check whether including a nickname in a message is enough to make Matrix client trigger a "you were mentioned" notification, or if we need some kind of markup in task.extra.notify.matrixFormattedBody (see https://docs.taskcluster.net/docs/reference/core/notify/usage)

@SimonSapin
Copy link
Member

SimonSapin commented Apr 9, 2020

TC now can now send to Matrix but uses "notices", which are ignored by Riot for the purpose of triggering desktop notifications. I’ve filed taskcluster/taskcluster#2628 to add an opt out and make it send "normal" messages instead.

@jdm
Copy link
Member Author

jdm commented Jul 20, 2020

We're doing ok without these so far.

@jdm jdm closed this Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.