Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable windows unit tests #25980

Merged
merged 2 commits into from Mar 20, 2020
Merged

Enable windows unit tests #25980

merged 2 commits into from Mar 20, 2020

Conversation

@jdm
Copy link
Member

jdm commented Mar 17, 2020

Fixes #25961.
jdm added 2 commits Mar 17, 2020
@jdm
Copy openssl DLLs to unit test directory.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
d30e51b
@jdm
Re-enable windows unit tests.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d4ed646
@highfive
Copy link

highfive commented Mar 17, 2020

Heads up! This PR modifies the following files:
@jdm
Copy link
Member Author

jdm commented Mar 17, 2020

@bors-servo try=windows
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

⌛ Trying commit d4ed646 with merge b14bcfe...
bors-servo added a commit that referenced this pull request Mar 17, 2020
@bors-servo
Auto merge of #25980 - servo:jdm-patch-44, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b14bcfe 
Enable windows unit tests

Fixes #25961.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 17, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@jdm
Copy link
Member Author

jdm commented Mar 19, 2020

r? @paulrouget
@highfive highfive assigned paulrouget and unassigned asajeffrey Mar 19, 2020
@paulrouget
Copy link
Contributor

paulrouget commented Mar 20, 2020

oh nice!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2020

📌 Commit d4ed646 has been approved by paulrouget
@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2020

⌛ Testing commit d4ed646 with merge d29b1c2...
bors-servo added a commit that referenced this pull request Mar 20, 2020
@bors-servo
Auto merge of #25980 - servo:jdm-patch-44, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d29b1c2 
Enable windows unit tests

Fixes #25961.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Mar 20, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2020

⌛ Testing commit d4ed646 with merge c5b1849...
bors-servo added a commit that referenced this pull request Mar 20, 2020
@bors-servo
Auto merge of #25980 - servo:jdm-patch-44, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c5b1849 
Enable windows unit tests

Fixes #25961.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Mar 20, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2020

⌛ Testing commit d4ed646 with merge 7ef4c65...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 20, 2020

☀️ Test successful - status-taskcluster
Approved by: paulrouget
Pushing 7ef4c65 to master...
@bors-servo bors-servo merged commit 7ef4c65 into master Mar 20, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the jdm-patch-44 branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paulrouget paulrouget

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Windows unit test failure on windows server 2019 (exit code: 0xc0000139, STATUS_ENTRYPOINT_NOT_FOUND)
5 participants
@jdm @highfive @bors-servo @paulrouget @asajeffrey
You can’t perform that action at this time.