Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update x11-dl to pickup the fix for x11 startup crash (recurrence of #21530) #25983

Merged
merged 1 commit into from Mar 19, 2020

Conversation

@vbkaisetsu
Copy link
Contributor

vbkaisetsu commented Mar 19, 2020

This branch updates x11-dl to 2.18.5 to get erlepereira/x11-rs#99

% ./mach run --release https://duckduckgo.com                             
attempted to leave type `std::mem::ManuallyDrop<xlib_xcb::Xlib_xcb>` uninitialized, which is invalid (thread main, at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb/src/libcore/mem/mod.rs:536)     
stack backtrace:                                                                                   
   0: servo::backtrace::print                   
   1: servo::main::{{closure}}        
   2: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:513                                                        
   3: rust_begin_unwind                       
             at src/libstd/panicking.rs:417                                                        
   4: core::panicking::panic_fmt
             at src/libcore/panicking.rs:111                                                       
   5: core::panicking::panic                     
             at src/libcore/panicking.rs:54 
   6: x11_dl::xlib_xcb::Xlib_xcb::open                                                                                                                                                                
   7: winit::platform::platform::x11::xdisplay::XConnection::new                                   
   8: std::sync::once::Once::call_once::{{closure}}                 
   9: std::sync::once::Once::call_inner          
             at src/libstd/sync/once.rs:416
  10: winit::platform::platform::EventsLoop::new_x11
  11: winit::platform::platform::EventsLoop::new
  12: winit::EventsLoop::new
  13: servo::events_loop::EventsLoop::new
  14: servo::app::App::run
  15: servo::main
  16: std::rt::lang_start::{{closure}}
  17: std::rt::lang_start_internal::{{closure}}
             at src/libstd/rt.rs:52
      std::panicking::try::do_call
             at src/libstd/panicking.rs:329
      std::panicking::try::do_try
             at src/libstd/panicking.rs:285
      std::panicking::try
             at src/libstd/panicking.rs:274
      std::panic::catch_unwind
             at src/libstd/panic.rs:394
      std::rt::lang_start_internal
             at src/libstd/rt.rs:51
  18: main
  19: __libc_start_main
  20: _start
Servo exited with return value 101

This patch is created by cargo update -p x11-dl.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because it fixes a startup crash
@highfive
Copy link

highfive commented Mar 19, 2020

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.

@jdm
Copy link
Member

jdm commented Mar 19, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2020

📌 Commit 9f892eb has been approved by jdm

@highfive highfive assigned jdm and unassigned nox Mar 19, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2020

Testing commit 9f892eb with merge 2b0a48f...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 2b0a48f to master...

@bors-servo bors-servo merged commit 2b0a48f into servo:master Mar 19, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@vbkaisetsu vbkaisetsu deleted the vbkaisetsu:fix/come-back-21532 branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.