Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content-security-policy. #26005

Merged
merged 1 commit into from Mar 25, 2020
Merged

Update content-security-policy. #26005

merged 1 commit into from Mar 25, 2020

Conversation

@jdm
Copy link
Member

jdm commented Mar 20, 2020

This allows hubs.mozilla.org to load instead of panicking due to unimplemented CSP features.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #24702
  • These changes do not require tests because we never enabled the CSP testsuite
@highfive
Copy link

highfive commented Mar 20, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlscriptelement.rs, components/script/Cargo.toml
  • @KiChjang: components/net/Cargo.toml, components/net/fetch/methods.rs, components/script/dom/htmlscriptelement.rs, components/script/Cargo.toml, components/net_traits/Cargo.toml
@highfive
Copy link

highfive commented Mar 20, 2020

warning Warning warning

  • These commits modify net and script code, but no tests are modified. Please consider adding a test!
@nox
nox reviewed Mar 23, 2020
View changes
Cargo.lock
@@ -239,6 +239,12 @@ version = "0.11.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "b41b7ea54a0c9d92199de89e20e58d49f02f8e699814ef3fdf266f6f748d15c7"

[[package]]
name = "base64"
version = "0.12.0"

This comment has been minimized.

Sign in to view
Copy link
@nox

nox Mar 23, 2020

Member

Oof, unfortunate that we now carry 3 copies of base64.
@nox
Copy link
Member

nox commented Mar 23, 2020

@bors-servo r+

Not sure what to think about this bringing in ring, but oh well.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2020

📌 Commit ad1bec1 has been approved by nox
@highfive highfive assigned nox and unassigned asajeffrey Mar 23, 2020
@nox nox mentioned this pull request Mar 23, 2020
Open
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2020

⌛ Testing commit ad1bec1 with merge 80d5923...
bors-servo added a commit that referenced this pull request Mar 23, 2020
@bors-servo
Auto merge of #26005 - jdm:hubs-csp, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
80d5923 
Update content-security-policy.

This allows hubs.mozilla.org to load instead of panicking due to unimplemented CSP features.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24702
- [x] These changes do not require tests because we never enabled the CSP testsuite
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Mar 23, 2020 •
edited

Not sure if it's relevent 👀

UWP build failure 
error: failed to run custom build command for `ring v0.16.11`

Caused by:
  process didn't exit successfully: `C:\Users\task_1584958359\repo\target\debug\build\ring-a625ec479488812b\build-script-build` (exit code: 101)
--- stdout
=C:: C:\Users\task_1584958359\repo
ALLUSERSPROFILE: C:\ProgramData
ANDROID_PLATFORM: android-21
APPDATA: C:\Users\task_1584958359\AppData\Roaming
AUTOCONF: C:\Users\task_1584958359\repo\.servo\msvc-dependencies\moztools\3.2\msys\local\bin\autoconf-2.13
CARGO: \\?\C:\Users\task_1584958359\.rustup\toolchains\nightly-2020-03-16-x86_64-pc-windows-msvc\bin\cargo.exe
CARGO_CFG_TARGET_ARCH: aarch64
CARGO_CFG_TARGET_ENDIAN: little
CARGO_CFG_TARGET_ENV: msvc
CARGO_CFG_TARGET_FAMILY: windows
CARGO_CFG_TARGET_FEATURE: fp,neon
CARGO_CFG_TARGET_HAS_ATOMIC: 16,32,64,8,ptr
CARGO_CFG_TARGET_HAS_ATOMIC_LOAD_STORE: 16,32,64,8,ptr
CARGO_CFG_TARGET_OS: windows
CARGO_CFG_TARGET_POINTER_WIDTH: 64
CARGO_CFG_TARGET_THREAD_LOCAL: 
CARGO_CFG_TARGET_VENDOR: uwp
CARGO_CFG_WINDOWS: 
CARGO_FEATURE_ALLOC: 1
CARGO_FEATURE_DEFAULT: 1
CARGO_FEATURE_DEV_URANDOM_FALLBACK: 1
CARGO_FEATURE_LAZY_STATIC: 1
CARGO_HOME: C:\Users\task_1584958359\.cargo
CARGO_INCREMENTAL: 0
CARGO_MAKEFLAGS: --jobserver-fds=__rust_jobserver_semaphore_1186269732 --jobserver-auth=__rust_jobserver_semaphore_1186269732
CARGO_MANIFEST_DIR: C:\Users\task_1584958359\.cargo\registry\src\github.com-1ecc6299db9ec823\ring-0.16.11
CARGO_MANIFEST_LINKS: ring-asm
CARGO_PKG_AUTHORS: Brian Smith <brian@briansmith.org>
CARGO_PKG_DESCRIPTION: Safe, fast, small crypto using Rust.
CARGO_PKG_HOMEPAGE: 
CARGO_PKG_NAME: ring
CARGO_PKG_REPOSITORY: https://github.com/briansmith/ring
CARGO_PKG_VERSION: 0.16.11
CARGO_PKG_VERSION_MAJOR: 0
CARGO_PKG_VERSION_MINOR: 16
CARGO_PKG_VERSION_PATCH: 11
CARGO_PKG_VERSION_PRE: 
CARGO_TARGET_DIR: C:\Users\task_1584958359\repo\target
CC: clang-cl.exe
CFLAGS:  -DWINAPI_FAMILY=WINAPI_FAMILY_APP
COMMONPROGRAMFILES: C:\Program Files\Common Files
COMMONPROGRAMFILES(X86): C:\Program Files (x86)\Common Files
COMMONPROGRAMW6432: C:\Program Files\Common Files
COMPUTERNAME: EC2AMAZ-BF0I3JE
COMSPEC: C:\Windows\system32\cmd.exe
CXX: clang-cl.exe
CXXFLAGS:  -DWINAPI_FAMILY=WINAPI_FAMILY_APP
DEBUG: true
DRIVERDATA: C:\Windows\System32\Drivers\DriverData
GIT_INFO: -befffb5b6
GSTREAMER_1_0_ROOT_ARM64: C:\Users\task_1584958359\repo\.servo\msvc-dependencies\gstreamer-uwp\1.16.0.5\arm64
HARFBUZZ_SYS_NO_PKG_CONFIG: true
HOMEDRIVE: C:
HOMEPATH: \Users\task_1584958359
HOST: x86_64-pc-windows-msvc
LD_LIBRARY_PATH: C:\Users\task_1584958359\.rustup\toolchains\nightly-2020-03-16-x86_64-pc-windows-msvc\lib
LIB: C:\Users\task_1584958359\repo\support\hololens\packages\ANGLE.WindowsStore.Servo.2.1.16\bin\UAP\arm64;C:\Users\task_1584958359\repo\.servo\msvc-dependencies\gstreamer-uwp\1.16.0.5\arm64\lib
LIBCLANG_PATH: C:\Users\task_1584958359\repo\.servo\msvc-dependencies\llvm\8.0.1\lib
LINKER: lld-link.exe
LOCALAPPDATA: C:\Users\task_1584958359\AppData\Local
LOGONSERVER: \\EC2AMAZ-BF0I3JE
MOZTOOLS_PATH: C:\Users\task_1584958359\git\cmd;C:\Users\task_1584958359\repo\.servo\msvc-dependencies\moztools\3.2\bin;C:\Users\task_1584958359\repo\.servo\msvc-dependencies\moztools\3.2\msys\bin
MOZTOOLS_PATH_PREPEND: C:\Users\task_1584958359\git\cmd
NATIVE_WIN32_PYTHON: C:\Users\task_1584958359\python2\python.exe
NUMBER_OF_PROCESSORS: 8
NUM_JOBS: 8
OPENSSL_INCLUDE_DIR: C:\Users\task_1584958359\repo\.servo\msvc-dependencies\openssl\111.3.0+1.1.1c-vs2017-2019-09-18\arm64-windows-uwp\include
OPENSSL_LIBS: libssl:libcrypto
OPENSSL_LIB_DIR: C:\Users\task_1584958359\repo\.servo\msvc-dependencies\openssl\111.3.0+1.1.1c-vs2017-2019-09-18\arm64-windows-uwp\lib
OPT_LEVEL: 0
OS: Windows_NT
OUT_DIR: C:\Users\task_1584958359\repo\target\aarch64-uwp-windows-msvc\debug\build\ring-93e456cefa8252ef\out
PATH: C:\Users\task_1584958359\repo\target\debug\deps;C:\Users\task_1584958359\.rustup\toolchains\nightly-2020-03-16-x86_64-pc-windows-msvc\bin;C:\Users\task_1584958359\.cargo\bin;C:\Users\task_1584958359\.rustup\toolchains\nightly-2020-03-16-x86_64-pc-windows-msvc\bin;C:\Users\task_1584958359\repo\python\_virtualenv2.7\Scripts;C:\Users\task_1584958359\curl\curl-7.67.0-win64-mingw\bin;C:\Users\task_1584958359\git\cmd;C:\Users\task_1584958359\python2;C:\Users\task_1584958359\python2\Scripts;C:\Users\task_1584958359\.cargo\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\Amazon\cfn-bootstrap\;C:\Users\task_1584958359\AppData\Local\Microsoft\WindowsApps;C:\Users\task_1584958359\repo\.servo\msvc-dependencies\cmake\3.14.3\bin;C:\Users\task_1584958359\repo\.servo\msvc-dependencies\llvm\8.0.1\bin;C:\Users\task_1584958359\repo\.servo\msvc-dependencies\ninja\1.7.1\bin;C:\Users\task_1584958359\repo\.servo\msvc-dependencies\nuget\08-08-2019;C:\Users\task_1584958359\repo\.servo\msvc-dependencies\xargo\v0.3.17
PATHEXT: .COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC
PKG_CONFIG_ALLOW_CROSS: 1
PKG_CONFIG_PATH: C:\Users\task_1584958359\repo\.servo\msvc-dependencies\gstreamer-uwp\1.16.0.5\arm64\lib\pkgconfig
PROCESSOR_ARCHITECTURE: AMD64
PROCESSOR_IDENTIFIER: Intel64 Family 6 Model 85 Stepping 7, GenuineIntel
PROCESSOR_LEVEL: 6
PROCESSOR_REVISION: 5507
PROFILE: debug
PROGRAMDATA: C:\ProgramData
PROGRAMFILES: C:\Program Files
PROGRAMFILES(X86): C:\Program Files (x86)
PROGRAMW6432: C:\Program Files
PROMPT: $P$G
PSMODULEPATH: C:\Program Files\WindowsPowerShell\Modules;C:\Windows\system32\WindowsPowerShell\v1.0\Modules;C:\Program Files (x86)\AWS Tools\PowerShell\
PUBLIC: C:\Users\Public
PYTHON3: C:\Users\task_1584958359\python3\python.exe
RUN_ID: 0
RUSTC: rustc
RUSTC_LINKER: lld-link.exe
RUSTDOC: C:\Users\task_1584958359\repo\etc\rustdoc-with-private
RUSTFLAGS: -Dwarnings -C target-feature=+neon -W unused-extern-crates --sysroot C:\Users\task_1584958359\.xargo
RUSTUP_HOME: C:\Users\task_1584958359\.rustup
RUSTUP_TOOLCHAIN: nightly-2020-03-16-x86_64-pc-windows-msvc
RUST_BACKTRACE: 1
RUST_RECURSION_COUNT: 1
RUST_SYSROOT: C:\Users\task_1584958359\.xargo
SYSTEMDRIVE: C:
SYSTEMROOT: C:\Windows
TARGET: aarch64-uwp-windows-msvc
TASKCLUSTER_PROXY_URL: http://localhost:80
TASKCLUSTER_ROOT_URL: https://community-tc.services.mozilla.com
TASKCLUSTER_WORKER_LOCATION: {"cloud":"aws","region":"us-west-2","availabilityZone":"us-west-2a"}
TASK_ID: QUTT7ElCQPuTDOBeb17q7A
TCEXITCODE: 0
TEMP: C:\Users\TASK_1~2\AppData\Local\Temp
TMP: C:\Users\TASK_1~2\AppData\Local\Temp
USERDOMAIN: EC2AMAZ-BF0I3JE
USERDOMAIN_ROAMINGPROFILE: EC2AMAZ-BF0I3JE
USERNAME: task_1584958359
USERPROFILE: C:\Users\task_1584958359
WINDIR: C:\Windows
OPT_LEVEL = Some("0")
TARGET = Some("aarch64-uwp-windows-msvc")
HOST = Some("x86_64-pc-windows-msvc")
CC_aarch64-uwp-windows-msvc = None
CC_aarch64_uwp_windows_msvc = None
TARGET_CC = None
CC = Some("clang-cl.exe")
CFLAGS_aarch64-uwp-windows-msvc = None
CFLAGS_aarch64_uwp_windows_msvc = None
TARGET_CFLAGS = None
CFLAGS = Some(" -DWINAPI_FAMILY=WINAPI_FAMILY_APP")
CRATE_CC_NO_DEFAULTS = None
CARGO_CFG_TARGET_FEATURE = Some("fp,neon")
DEBUG = Some("true")
running "clang-cl.exe" "-nologo" "-MD" "-Z7" "-Brepro" "--target=aarch64-uwp-windows-msvc" "-DWINAPI_FAMILY=WINAPI_FAMILY_APP" "-I" "include" "/GS" "/Gy" "/EHsc" "/GR-" "/Zc:wchar_t" "/Zc:forScope" "/Zc:inline" "/Zc:rvalueCast" "/sdl" "/Wall" "/wd4127" "/wd4464" "/wd4514" "/wd4710" "/wd4711" "/wd4820" "/wd5045" "/Od" "/RTCsu" "-DNDEBUG" "-c" "/FoC:\\Users\\task_1584958359\\repo\\target\\aarch64-uwp-windows-msvc\\debug\\build\\ring-93e456cefa8252ef\\out\\generic.obj" "crypto/fipsmodule/bn/generic.c"
OPT_LEVEL = Some("0")
TARGET = Some("aarch64-uwp-windows-msvc")
HOST = Some("x86_64-pc-windows-msvc")
CC_aarch64-uwp-windows-msvc = None
CC_aarch64_uwp_windows_msvc = None
TARGET_CC = None
CC = Some("clang-cl.exe")
CFLAGS_aarch64-uwp-windows-msvc = None
CFLAGS_aarch64_uwp_windows_msvc = None
TARGET_CFLAGS = None
CFLAGS = Some(" -DWINAPI_FAMILY=WINAPI_FAMILY_APP")
CRATE_CC_NO_DEFAULTS = None
CARGO_CFG_TARGET_FEATURE = Some("fp,neon")
DEBUG = Some("true")
running "clang-cl.exe" "-nologo" "-MD" "-Z7" "-Brepro" "--target=aarch64-uwp-windows-msvc" "-DWINAPI_FAMILY=WINAPI_FAMILY_APP" "-I" "include" "/GS" "/Gy" "/EHsc" "/GR-" "/Zc:wchar_t" "/Zc:forScope" "/Zc:inline" "/Zc:rvalueCast" "/sdl" "/Wall" "/wd4127" "/wd4464" "/wd4514" "/wd4710" "/wd4711" "/wd4820" "/wd5045" "/Od" "/RTCsu" "-DNDEBUG" "-c" "/FoC:\\Users\\task_1584958359\\repo\\target\\aarch64-uwp-windows-msvc\\debug\\build\\ring-93e456cefa8252ef\\out\\montgomery.obj" "crypto/fipsmodule/bn/montgomery.c"
OPT_LEVEL = Some("0")
TARGET = Some("aarch64-uwp-windows-msvc")
HOST = Some("x86_64-pc-windows-msvc")
CC_aarch64-uwp-windows-msvc = None
CC_aarch64_uwp_windows_msvc = None
TARGET_CC = None
CC = Some("clang-cl.exe")
CFLAGS_aarch64-uwp-windows-msvc = None
CFLAGS_aarch64_uwp_windows_msvc = None
TARGET_CFLAGS = None
CFLAGS = Some(" -DWINAPI_FAMILY=WINAPI_FAMILY_APP")
CRATE_CC_NO_DEFAULTS = None
CARGO_CFG_TARGET_FEATURE = Some("fp,neon")
DEBUG = Some("true")
running "clang-cl.exe" "-nologo" "-MD" "-Z7" "-Brepro" "--target=aarch64-uwp-windows-msvc" "-DWINAPI_FAMILY=WINAPI_FAMILY_APP" "-I" "include" "/GS" "/Gy" "/EHsc" "/GR-" "/Zc:wchar_t" "/Zc:forScope" "/Zc:inline" "/Zc:rvalueCast" "/sdl" "/Wall" "/wd4127" "/wd4464" "/wd4514" "/wd4710" "/wd4711" "/wd4820" "/wd5045" "/Od" "/RTCsu" "-DNDEBUG" "-c" "/FoC:\\Users\\task_1584958359\\repo\\target\\aarch64-uwp-windows-msvc\\debug\\build\\ring-93e456cefa8252ef\\out\\montgomery_inv.obj" "crypto/fipsmodule/bn/montgomery_inv.c"
OPT_LEVEL = Some("0")
TARGET = Some("aarch64-uwp-windows-msvc")
HOST = Some("x86_64-pc-windows-msvc")
CC_aarch64-uwp-windows-msvc = None
CC_aarch64_uwp_windows_msvc = None
TARGET_CC = None
CC = Some("clang-cl.exe")
CFLAGS_aarch64-uwp-windows-msvc = None
CFLAGS_aarch64_uwp_windows_msvc = None
TARGET_CFLAGS = None
CFLAGS = Some(" -DWINAPI_FAMILY=WINAPI_FAMILY_APP")
CRATE_CC_NO_DEFAULTS = None
CARGO_CFG_TARGET_FEATURE = Some("fp,neon")
DEBUG = Some("true")
running "clang-cl.exe" "-nologo" "-MD" "-Z7" "-Brepro" "--target=aarch64-uwp-windows-msvc" "-DWINAPI_FAMILY=WINAPI_FAMILY_APP" "-I" "include" "/GS" "/Gy" "/EHsc" "/GR-" "/Zc:wchar_t" "/Zc:forScope" "/Zc:inline" "/Zc:rvalueCast" "/sdl" "/Wall" "/wd4127" "/wd4464" "/wd4514" "/wd4710" "/wd4711" "/wd4820" "/wd5045" "/Od" "/RTCsu" "-DNDEBUG" "-c" "/FoC:\\Users\\task_1584958359\\repo\\target\\aarch64-uwp-windows-msvc\\debug\\build\\ring-93e456cefa8252ef\\out\\crypto.obj" "crypto/crypto.c"
OPT_LEVEL = Some("0")
TARGET = Some("aarch64-uwp-windows-msvc")
HOST = Some("x86_64-pc-windows-msvc")
CC_aarch64-uwp-windows-msvc = None
CC_aarch64_uwp_windows_msvc = None
TARGET_CC = None
CC = Some("clang-cl.exe")
CFLAGS_aarch64-uwp-windows-msvc = None
CFLAGS_aarch64_uwp_windows_msvc = None
TARGET_CFLAGS = None
CFLAGS = Some(" -DWINAPI_FAMILY=WINAPI_FAMILY_APP")
CRATE_CC_NO_DEFAULTS = None
CARGO_CFG_TARGET_FEATURE = Some("fp,neon")
DEBUG = Some("true")
running "clang-cl.exe" "-nologo" "-MD" "-Z7" "-Brepro" "--target=aarch64-uwp-windows-msvc" "-DWINAPI_FAMILY=WINAPI_FAMILY_APP" "-I" "include" "/GS" "/Gy" "/EHsc" "/GR-" "/Zc:wchar_t" "/Zc:forScope" "/Zc:inline" "/Zc:rvalueCast" "/sdl" "/Wall" "/wd4127" "/wd4464" "/wd4514" "/wd4710" "/wd4711" "/wd4820" "/wd5045" "/Od" "/RTCsu" "-DNDEBUG" "-c" "/FoC:\\Users\\task_1584958359\\repo\\target\\aarch64-uwp-windows-msvc\\debug\\build\\ring-93e456cefa8252ef\\out\\ecp_nistz.obj" "crypto/fipsmodule/ec/ecp_nistz.c"
OPT_LEVEL = Some("0")
TARGET = Some("aarch64-uwp-windows-msvc")
HOST = Some("x86_64-pc-windows-msvc")
CC_aarch64-uwp-windows-msvc = None
CC_aarch64_uwp_windows_msvc = None
TARGET_CC = None
CC = Some("clang-cl.exe")
CFLAGS_aarch64-uwp-windows-msvc = None
CFLAGS_aarch64_uwp_windows_msvc = None
TARGET_CFLAGS = None
CFLAGS = Some(" -DWINAPI_FAMILY=WINAPI_FAMILY_APP")
CRATE_CC_NO_DEFAULTS = None
CARGO_CFG_TARGET_FEATURE = Some("fp,neon")
DEBUG = Some("true")
running "clang-cl.exe" "-nologo" "-MD" "-Z7" "-Brepro" "--target=aarch64-uwp-windows-msvc" "-DWINAPI_FAMILY=WINAPI_FAMILY_APP" "-I" "include" "/GS" "/Gy" "/EHsc" "/GR-" "/Zc:wchar_t" "/Zc:forScope" "/Zc:inline" "/Zc:rvalueCast" "/sdl" "/Wall" "/wd4127" "/wd4464" "/wd4514" "/wd4710" "/wd4711" "/wd4820" "/wd5045" "/Od" "/RTCsu" "-DNDEBUG" "-c" "/FoC:\\Users\\task_1584958359\\repo\\target\\aarch64-uwp-windows-msvc\\debug\\build\\ring-93e456cefa8252ef\\out\\ecp_nistz256.obj" "crypto/fipsmodule/ec/ecp_nistz256.c"
OPT_LEVEL = Some("0")
TARGET = Some("aarch64-uwp-windows-msvc")
HOST = Some("x86_64-pc-windows-msvc")
CC_aarch64-uwp-windows-msvc = None
CC_aarch64_uwp_windows_msvc = None
TARGET_CC = None
CC = Some("clang-cl.exe")
CFLAGS_aarch64-uwp-windows-msvc = None
CFLAGS_aarch64_uwp_windows_msvc = None
TARGET_CFLAGS = None
CFLAGS = Some(" -DWINAPI_FAMILY=WINAPI_FAMILY_APP")
CRATE_CC_NO_DEFAULTS = None
CARGO_CFG_TARGET_FEATURE = Some("fp,neon")
DEBUG = Some("true")
running "clang-cl.exe" "-nologo" "-MD" "-Z7" "-Brepro" "--target=aarch64-uwp-windows-msvc" "-DWINAPI_FAMILY=WINAPI_FAMILY_APP" "-I" "include" "/GS" "/Gy" "/EHsc" "/GR-" "/Zc:wchar_t" "/Zc:forScope" "/Zc:inline" "/Zc:rvalueCast" "/sdl" "/Wall" "/wd4127" "/wd4464" "/wd4514" "/wd4710" "/wd4711" "/wd4820" "/wd5045" "/Od" "/RTCsu" "-DNDEBUG" "-c" "/FoC:\\Users\\task_1584958359\\repo\\target\\aarch64-uwp-windows-msvc\\debug\\build\\ring-93e456cefa8252ef\\out\\gfp_p256.obj" "crypto/fipsmodule/ec/gfp_p256.c"
OPT_LEVEL = Some("0")
TARGET = Some("aarch64-uwp-windows-msvc")
HOST = Some("x86_64-pc-windows-msvc")
CC_aarch64-uwp-windows-msvc = None
CC_aarch64_uwp_windows_msvc = None
TARGET_CC = None
CC = Some("clang-cl.exe")
CFLAGS_aarch64-uwp-windows-msvc = None
CFLAGS_aarch64_uwp_windows_msvc = None
TARGET_CFLAGS = None
CFLAGS = Some(" -DWINAPI_FAMILY=WINAPI_FAMILY_APP")
CRATE_CC_NO_DEFAULTS = None
CARGO_CFG_TARGET_FEATURE = Some("fp,neon")
DEBUG = Some("true")
running "clang-cl.exe" "-nologo" "-MD" "-Z7" "-Brepro" "--target=aarch64-uwp-windows-msvc" "-DWINAPI_FAMILY=WINAPI_FAMILY_APP" "-I" "include" "/GS" "/Gy" "/EHsc" "/GR-" "/Zc:wchar_t" "/Zc:forScope" "/Zc:inline" "/Zc:rvalueCast" "/sdl" "/Wall" "/wd4127" "/wd4464" "/wd4514" "/wd4710" "/wd4711" "/wd4820" "/wd5045" "/Od" "/RTCsu" "-DNDEBUG" "-c" "/FoC:\\Users\\task_1584958359\\repo\\target\\aarch64-uwp-windows-msvc\\debug\\build\\ring-93e456cefa8252ef\\out\\gfp_p384.obj" "crypto/fipsmodule/ec/gfp_p384.c"
OPT_LEVEL = Some("0")
TARGET = Some("aarch64-uwp-windows-msvc")
HOST = Some("x86_64-pc-windows-msvc")
CC_aarch64-uwp-windows-msvc = None
CC_aarch64_uwp_windows_msvc = None
TARGET_CC = None
CC = Some("clang-cl.exe")
CFLAGS_aarch64-uwp-windows-msvc = None
CFLAGS_aarch64_uwp_windows_msvc = None
TARGET_CFLAGS = None
CFLAGS = Some(" -DWINAPI_FAMILY=WINAPI_FAMILY_APP")
CRATE_CC_NO_DEFAULTS = None
CARGO_CFG_TARGET_FEATURE = Some("fp,neon")
DEBUG = Some("true")
running "clang-cl.exe" "-nologo" "-MD" "-Z7" "-Brepro" "--target=aarch64-uwp-windows-msvc" "-DWINAPI_FAMILY=WINAPI_FAMILY_APP" "-I" "include" "/GS" "/Gy" "/EHsc" "/GR-" "/Zc:wchar_t" "/Zc:forScope" "/Zc:inline" "/Zc:rvalueCast" "/sdl" "/Wall" "/wd4127" "/wd4464" "/wd4514" "/wd4710" "/wd4711" "/wd4820" "/wd5045" "/Od" "/RTCsu" "-DNDEBUG" "-c" "/FoC:\\Users\\task_1584958359\\repo\\target\\aarch64-uwp-windows-msvc\\debug\\build\\ring-93e456cefa8252ef\\out\\limbs.obj" "crypto/limbs/limbs.c"
OPT_LEVEL = Some("0")
TARGET = Some("aarch64-uwp-windows-msvc")
HOST = Some("x86_64-pc-windows-msvc")
CC_aarch64-uwp-windows-msvc = None
CC_aarch64_uwp_windows_msvc = None
TARGET_CC = None
CC = Some("clang-cl.exe")
CFLAGS_aarch64-uwp-windows-msvc = None
CFLAGS_aarch64_uwp_windows_msvc = None
TARGET_CFLAGS = None
CFLAGS = Some(" -DWINAPI_FAMILY=WINAPI_FAMILY_APP")
CRATE_CC_NO_DEFAULTS = None
CARGO_CFG_TARGET_FEATURE = Some("fp,neon")
DEBUG = Some("true")
running "clang-cl.exe" "-nologo" "-MD" "-Z7" "-Brepro" "--target=aarch64-uwp-windows-msvc" "-DWINAPI_FAMILY=WINAPI_FAMILY_APP" "-I" "include" "/GS" "/Gy" "/EHsc" "/GR-" "/Zc:wchar_t" "/Zc:forScope" "/Zc:inline" "/Zc:rvalueCast" "/sdl" "/Wall" "/wd4127" "/wd4464" "/wd4514" "/wd4710" "/wd4711" "/wd4820" "/wd5045" "/Od" "/RTCsu" "-DNDEBUG" "-c" "/FoC:\\Users\\task_1584958359\\repo\\target\\aarch64-uwp-windows-msvc\\debug\\build\\ring-93e456cefa8252ef\\out\\mem.obj" "crypto/mem.c"
OPT_LEVEL = Some("0")
TARGET = Some("aarch64-uwp-windows-msvc")
HOST = Some("x86_64-pc-windows-msvc")
CC_aarch64-uwp-windows-msvc = None
CC_aarch64_uwp_windows_msvc = None
TARGET_CC = None
CC = Some("clang-cl.exe")
CFLAGS_aarch64-uwp-windows-msvc = None
CFLAGS_aarch64_uwp_windows_msvc = None
TARGET_CFLAGS = None
CFLAGS = Some(" -DWINAPI_FAMILY=WINAPI_FAMILY_APP")
CRATE_CC_NO_DEFAULTS = None
CARGO_CFG_TARGET_FEATURE = Some("fp,neon")
DEBUG = Some("true")
running "clang-cl.exe" "-nologo" "-MD" "-Z7" "-Brepro" "--target=aarch64-uwp-windows-msvc" "-DWINAPI_FAMILY=WINAPI_FAMILY_APP" "-I" "include" "/GS" "/Gy" "/EHsc" "/GR-" "/Zc:wchar_t" "/Zc:forScope" "/Zc:inline" "/Zc:rvalueCast" "/sdl" "/Wall" "/wd4127" "/wd4464" "/wd4514" "/wd4710" "/wd4711" "/wd4820" "/wd5045" "/Od" "/RTCsu" "-DNDEBUG" "-c" "/FoC:\\Users\\task_1584958359\\repo\\target\\aarch64-uwp-windows-msvc\\debug\\build\\ring-93e456cefa8252ef\\out\\gcm.obj" "crypto/fipsmodule/modes/gcm.c"
OPT_LEVEL = Some("0")
TARGET = Some("aarch64-uwp-windows-msvc")
HOST = Some("x86_64-pc-windows-msvc")
CC_aarch64-uwp-windows-msvc = None
CC_aarch64_uwp_windows_msvc = None
TARGET_CC = None
CC = Some("clang-cl.exe")
CFLAGS_aarch64-uwp-windows-msvc = None
CFLAGS_aarch64_uwp_windows_msvc = None
TARGET_CFLAGS = None
CFLAGS = Some(" -DWINAPI_FAMILY=WINAPI_FAMILY_APP")
CRATE_CC_NO_DEFAULTS = None
CARGO_CFG_TARGET_FEATURE = Some("fp,neon")
DEBUG = Some("true")
running "clang-cl.exe" "-nologo" "-MD" "-Z7" "-Brepro" "--target=aarch64-uwp-windows-msvc" "-DWINAPI_FAMILY=WINAPI_FAMILY_APP" "-I" "include" "/GS" "/Gy" "/EHsc" "/GR-" "/Zc:wchar_t" "/Zc:forScope" "/Zc:inline" "/Zc:rvalueCast" "/sdl" "/Wall" "/wd4127" "/wd4464" "/wd4514" "/wd4710" "/wd4711" "/wd4820" "/wd5045" "/Od" "/RTCsu" "-DNDEBUG" "-c" "/FoC:\\Users\\task_1584958359\\repo\\target\\aarch64-uwp-windows-msvc\\debug\\build\\ring-93e456cefa8252ef\\out\\curve25519.obj" "third_party/fiat/curve25519.c"

--- stderr
crypto/fipsmodule/bn/montgomery.c(120,5): warning: no previous prototype for function 'GFp_bn_from_montgomery_in_place' [-Wmissing-prototypes]
int GFp_bn_from_montgomery_in_place(BN_ULONG r[], size_t num_r, BN_ULONG a[],
    ^
1 warning generated.
crypto/fipsmodule/bn/montgomery_inv.c(49,10): warning: no previous prototype for function 'GFp_bn_neg_inv_mod_r_u64' [-Wmissing-prototypes]
uint64_t GFp_bn_neg_inv_mod_r_u64(uint64_t n) {
         ^
1 warning generated.
In file included from crypto/crypto.c:40:
include\GFp/arm_arch.h(104,9): warning: macro name is a reserved identifier [-Wreserved-id-macro]
#define __ARM_MAX_ARCH__ 8
        ^
crypto/crypto.c(42,17): warning: no previous extern declaration for non-static variable 'GFp_armcap_P' [-Wmissing-variable-declarations]
HIDDEN uint32_t GFp_armcap_P = 0;
                ^
2 warnings generated.
crypto/fipsmodule/ec/ecp_nistz256.c(69,15): warning: code will never be executed [-Wunreachable-code]
    dst[4] = (src[4] & mask1) ^ (dst[4] & mask2);
              ^~~
crypto/fipsmodule/ec/ecp_nistz256.c(68,21): note: silence by adding parentheses to mark code as explicitly dead
  if (P256_LIMBS == 8) {
                    ^
                    /* DISABLES CODE */ ( )
crypto/fipsmodule/ec/ecp_nistz256.c(118,6): warning: no previous prototype for function 'GFp_nistz256_point_add' [-Wmissing-prototypes]
void GFp_nistz256_point_add(P256_POINT *r, const P256_POINT *a, const P256_POINT *b) {
     ^
crypto/fipsmodule/ec/ecp_nistz256.c(256,36): warning: implicit conversion changes signedness: 'unsigned int' to 'int' [-Wsign-conversion]
  GFp_nistz256_select_w5(r, table, recoded);
  ~~~~~~~~~~~~~~~~~~~~~~           ^~~~~~~
crypto/fipsmodule/ec/ecp_nistz256.c(262,31): warning: implicit conversion changes signedness: 'int' to 'unsigned int' [-Wsign-conversion]
      raw_wvalue = p_str[off] | p_str[off + 1] << 8;
                 ~ ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
crypto/fipsmodule/ec/ecp_nistz256.c(266,41): warning: implicit conversion changes signedness: 'unsigned int' to 'int' [-Wsign-conversion]
      GFp_nistz256_select_w5(&h, table, recoded);
      ~~~~~~~~~~~~~~~~~~~~~~            ^~~~~~~
crypto/fipsmodule/ec/ecp_nistz256.c(287,37): warning: implicit conversion changes signedness: 'unsigned int' to 'int' [-Wsign-conversion]
  GFp_nistz256_select_w5(&h, table, recoded);
  ~~~~~~~~~~~~~~~~~~~~~~            ^~~~~~~
crypto/fipsmodule/ec/ecp_nistz256.c(202,6): warning: no previous prototype for function 'GFp_nistz256_point_mul' [-Wmissing-prototypes]
void GFp_nistz256_point_mul(P256_POINT *r, const Limb p_scalar[P256_LIMBS],
     ^
crypto/fipsmodule/ec/ecp_nistz256.c(300,58): warning: implicit conversion changes signedness: 'unsigned int' to 'int' [-Wsign-conversion]
  GFp_nistz256_select_w7(p, GFp_nistz256_precomputed[i], recoded);
  ~~~~~~~~~~~~~~~~~~~~~~                                 ^~~~~~~
crypto/fipsmodule/ec/ecp_nistz256.c(319,35): warning: implicit conversion changes signedness: 'int' to 'unsigned int' [-Wsign-conversion]
  unsigned raw_wvalue = (p_str[0] << 1) & kMask;
                         ~~~~~~~~~^~~~  ~
crypto/fipsmodule/ec/ecp_nistz256.c(331,29): warning: implicit conversion changes signedness: 'int' to 'unsigned int' [-Wsign-conversion]
    raw_wvalue = p_str[off] | p_str[off + 1] << 8;
               ~ ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
crypto/fipsmodule/ec/ecp_nistz256.c(306,6): warning: no previous prototype for function 'GFp_nistz256_point_mul_base' [-Wmissing-prototypes]
void GFp_nistz256_point_mul_base(P256_POINT *r,
     ^
11 warnings generated.
crypto/fipsmodule/ec/gfp_p256.c(36,6): warning: no previous prototype for function 'GFp_p256_scalar_mul_mont' [-Wmissing-prototypes]
void GFp_p256_scalar_mul_mont(ScalarMont r, const ScalarMont a,
     ^
crypto/fipsmodule/ec/gfp_p256.c(57,6): warning: no previous prototype for function 'GFp_p256_scalar_sqr_mont' [-Wmissing-prototypes]
void GFp_p256_scalar_sqr_mont(ScalarMont r, const ScalarMont a) {
     ^
2 warnings generated.
crypto/fipsmodule/ec/gfp_p384.c(184,6): warning: no previous prototype for function 'GFp_p384_elem_add' [-Wmissing-prototypes]
void GFp_p384_elem_add(Elem r, const Elem a, const Elem b) {
     ^
crypto/fipsmodule/ec/gfp_p384.c(188,6): warning: no previous prototype for function 'GFp_p384_elem_sub' [-Wmissing-prototypes]
void GFp_p384_elem_sub(Elem r, const Elem a, const Elem b) {
     ^
crypto/fipsmodule/ec/gfp_p384.c(192,6): warning: no previous prototype for function 'GFp_p384_elem_div_by_2' [-Wmissing-prototypes]
void GFp_p384_elem_div_by_2(Elem r, const Elem a) {
     ^
crypto/fipsmodule/ec/gfp_p384.c(196,6): warning: no previous prototype for function 'GFp_p384_elem_mul_mont' [-Wmissing-prototypes]
void GFp_p384_elem_mul_mont(Elem r, const Elem a, const Elem b) {
     ^
crypto/fipsmodule/ec/gfp_p384.c(200,6): warning: no previous prototype for function 'GFp_p384_elem_neg' [-Wmissing-prototypes]
void GFp_p384_elem_neg(Elem r, const Elem a) {
     ^
crypto/fipsmodule/ec/gfp_p384.c(213,6): warning: no previous prototype for function 'GFp_p384_scalar_mul_mont' [-Wmissing-prototypes]
void GFp_p384_scalar_mul_mont(ScalarMont r, const ScalarMont a,
     ^
In file included from crypto/fipsmodule/ec/gfp_p384.c:246:
crypto/fipsmodule/ec/ecp_nistz384.inl(32,6): warning: no previous prototype for function 'GFp_nistz384_point_double' [-Wmissing-prototypes]
void GFp_nistz384_point_double(P384_POINT *r, const P384_POINT *a) {
     ^
crypto/fipsmodule/ec/ecp_nistz384.inl(77,6): warning: no previous prototype for function 'GFp_nistz384_point_add' [-Wmissing-prototypes]
void GFp_nistz384_point_add(P384_POINT *r, const P384_POINT *a,
     ^
crypto/fipsmodule/ec/ecp_nistz384.inl(235,27): warning: implicit conversion changes signedness: 'int' to 'unsigned int' [-Wsign-conversion]
      wvalue = p_str[off] | p_str[off + 1] << 8;
             ~ ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
crypto/fipsmodule/ec/ecp_nistz384.inl(177,6): warning: no previous prototype for function 'GFp_nistz384_point_mul' [-Wmissing-prototypes]
void GFp_nistz384_point_mul(P384_POINT *r, const BN_ULONG p_scalar[P384_LIMBS],
     ^
10 warnings generated.
crypto/limbs/limbs.c(70,6): warning: no previous prototype for function 'LIMBS_less_than' [-Wmissing-prototypes]
Limb LIMBS_less_than(const Limb a[], const Limb b[], size_t num_limbs) {
     ^
crypto/limbs/limbs.c(83,6): warning: no previous prototype for function 'LIMBS_less_than_limb' [-Wmissing-prototypes]
Limb LIMBS_less_than_limb(const Limb a[], Limb b, size_t num_limbs) {
     ^
crypto/limbs/limbs.c(157,5): warning: no previous prototype for function 'LIMBS_select_512_32' [-Wmissing-prototypes]
int LIMBS_select_512_32(Limb r[], const Limb table[], size_t num_limbs,
    ^
crypto/limbs/limbs.c(168,13): warning: no previous prototype for function 'LIMBS_window5_split_window' [-Wmissing-prototypes]
crypto_word LIMBS_window5_split_window(Limb lower_limb, Limb higher_limb, size_t index_within_word) {
            ^
crypto/limbs/limbs.c(178,13): warning: no previous prototype for function 'LIMBS_window5_unsplit_window' [-Wmissing-prototypes]
crypto_word LIMBS_window5_unsplit_window(Limb limb, size_t index_within_word) {
            ^
crypto/limbs/limbs.c(182,6): warning: no previous prototype for function 'LIMB_shr' [-Wmissing-prototypes]
Limb LIMB_shr(Limb a, size_t shift) {
     ^
6 warnings generated.
crypto/fipsmodule/modes/gcm.c(86,37): warning: possible misuse of comma operator here [-Wcomma]
  Htable[3].hi = V.hi ^ Htable[2].hi, Htable[3].lo = V.lo ^ Htable[2].lo;
                                    ^
crypto/fipsmodule/modes/gcm.c(86,3): note: cast expression to void to silence warning
  Htable[3].hi = V.hi ^ Htable[2].hi, Htable[3].lo = V.lo ^ Htable[2].lo;
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  (void)(                           )
crypto/fipsmodule/modes/gcm.c(88,37): warning: possible misuse of comma operator here [-Wcomma]
  Htable[5].hi = V.hi ^ Htable[1].hi, Htable[5].lo = V.lo ^ Htable[1].lo;
                                    ^
crypto/fipsmodule/modes/gcm.c(88,3): note: cast expression to void to silence warning
  Htable[5].hi = V.hi ^ Htable[1].hi, Htable[5].lo = V.lo ^ Htable[1].lo;
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  (void)(                           )
crypto/fipsmodule/modes/gcm.c(89,37): warning: possible misuse of comma operator here [-Wcomma]
  Htable[6].hi = V.hi ^ Htable[2].hi, Htable[6].lo = V.lo ^ Htable[2].lo;
                                    ^
crypto/fipsmodule/modes/gcm.c(89,3): note: cast expression to void to silence warning
  Htable[6].hi = V.hi ^ Htable[2].hi, Htable[6].lo = V.lo ^ Htable[2].lo;
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  (void)(                           )
crypto/fipsmodule/modes/gcm.c(90,37): warning: possible misuse of comma operator here [-Wcomma]
  Htable[7].hi = V.hi ^ Htable[3].hi, Htable[7].lo = V.lo ^ Htable[3].lo;
                                    ^
crypto/fipsmodule/modes/gcm.c(90,3): note: cast expression to void to silence warning
  Htable[7].hi = V.hi ^ Htable[3].hi, Htable[7].lo = V.lo ^ Htable[3].lo;
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  (void)(                           )
crypto/fipsmodule/modes/gcm.c(92,37): warning: possible misuse of comma operator here [-Wcomma]
  Htable[9].hi = V.hi ^ Htable[1].hi, Htable[9].lo = V.lo ^ Htable[1].lo;
                                    ^
crypto/fipsmodule/modes/gcm.c(92,3): note: cast expression to void to silence warning
  Htable[9].hi = V.hi ^ Htable[1].hi, Htable[9].lo = V.lo ^ Htable[1].lo;
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  (void)(                           )
crypto/fipsmodule/modes/gcm.c(93,38): warning: possible misuse of comma operator here [-Wcomma]
  Htable[10].hi = V.hi ^ Htable[2].hi, Htable[10].lo = V.lo ^ Htable[2].lo;
                                     ^
crypto/fipsmodule/modes/gcm.c(93,3): note: cast expression to void to silence warning
  Htable[10].hi = V.hi ^ Htable[2].hi, Htable[10].lo = V.lo ^ Htable[2].lo;
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  (void)(                            )
crypto/fipsmodule/modes/gcm.c(94,38): warning: possible misuse of comma operator here [-Wcomma]
  Htable[11].hi = V.hi ^ Htable[3].hi, Htable[11].lo = V.lo ^ Htable[3].lo;
                                     ^
crypto/fipsmodule/modes/gcm.c(94,3): note: cast expression to void to silence warning
  Htable[11].hi = V.hi ^ Htable[3].hi, Htable[11].lo = V.lo ^ Htable[3].lo;
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  (void)(                            )
crypto/fipsmodule/modes/gcm.c(95,38): warning: possible misuse of comma operator here [-Wcomma]
  Htable[12].hi = V.hi ^ Htable[4].hi, Htable[12].lo = V.lo ^ Htable[4].lo;
                                     ^
crypto/fipsmodule/modes/gcm.c(95,3): note: cast expression to void to silence warning
  Htable[12].hi = V.hi ^ Htable[4].hi, Htable[12].lo = V.lo ^ Htable[4].lo;
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  (void)(                            )
crypto/fipsmodule/modes/gcm.c(96,38): warning: possible misuse of comma operator here [-Wcomma]
  Htable[13].hi = V.hi ^ Htable[5].hi, Htable[13].lo = V.lo ^ Htable[5].lo;
                                     ^
crypto/fipsmodule/modes/gcm.c(96,3): note: cast expression to void to silence warning
  Htable[13].hi = V.hi ^ Htable[5].hi, Htable[13].lo = V.lo ^ Htable[5].lo;
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  (void)(                            )
crypto/fipsmodule/modes/gcm.c(97,38): warning: possible misuse of comma operator here [-Wcomma]
  Htable[14].hi = V.hi ^ Htable[6].hi, Htable[14].lo = V.lo ^ Htable[6].lo;
                                     ^
crypto/fipsmodule/modes/gcm.c(97,3): note: cast expression to void to silence warning
  Htable[14].hi = V.hi ^ Htable[6].hi, Htable[14].lo = V.lo ^ Htable[6].lo;
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  (void)(                            )
crypto/fipsmodule/modes/gcm.c(98,38): warning: possible misuse of comma operator here [-Wcomma]
  Htable[15].hi = V.hi ^ Htable[7].hi, Htable[15].lo = V.lo ^ Htable[7].lo;
                                     ^
crypto/fipsmodule/modes/gcm.c(98,3): note: cast expression to void to silence warning
  Htable[15].hi = V.hi ^ Htable[7].hi, Htable[15].lo = V.lo ^ Htable[7].lo;
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  (void)(                            )
crypto/fipsmodule/modes/gcm.c(220,21): warning: possible misuse of comma operator here [-Wcomma]
  } while (inp += 16, len -= 16);
                    ^
crypto/fipsmodule/modes/gcm.c(220,12): note: cast expression to void to silence warning
  } while (inp += 16, len -= 16);
           ^~~~~~~~~
           (void)(  )
12 warnings generated.
In file included from third_party/fiat/curve25519.c:62:
third_party/fiat/./curve25519_64.h(43,34): warning: implicit conversion changes signedness: 'int64_t' (aka 'long long') to 'unsigned long long' [-Wsign-conversion]
  int64_t x1 = ((int64_t)(arg2 - (int64_t)arg1) - (int64_t)arg3);
                               ~ ^~~~~~~~~~~~~
third_party/fiat/./curve25519_64.h(45,18): warning: implicit conversion changes signedness: 'int64_t' (aka 'long long') to 'unsigned long long' [-Wsign-conversion]
  uint64_t x3 = (x1 & UINT64_C(0x7ffffffffffff));
                 ^~ ~
third_party/fiat/./curve25519_64.h(60,18): warning: implicit conversion changes signedness: 'fiat_25519_int1' (aka 'signed char') to 'unsigned long long' [-Wsign-conversion]
  uint64_t x2 = ((fiat_25519_int1)(0x0 - x1) & UINT64_C(0xffffffffffffffff));
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~ ~
third_party/fiat/curve25519.c(492,5): warning: no previous prototype for function 'GFp_x25519_ge_frombytes_vartime' [-Wmissing-prototypes]
int GFp_x25519_ge_frombytes_vartime(ge_p3 *h, const uint8_t s[32]) {
    ^
third_party/fiat/curve25519.c(684,16): warning: implicit conversion changes signedness: 'signed char' to 'uint8_t' (aka 'unsigned char') [-Wsign-conversion]
  uint8_t ub = b;
          ~~   ^
third_party/fiat/curve25519.c(685,16): warning: implicit conversion changes signedness: 'signed char' to 'uint8_t' (aka 'unsigned char') [-Wsign-conversion]
  uint8_t uc = c;
          ~~   ^
third_party/fiat/curve25519.c(690,10): warning: implicit conversion loses integer precision: 'uint32_t' (aka 'unsigned int') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  return y;
  ~~~~~~ ^
third_party/fiat/curve25519.c(762,16): warning: implicit conversion changes signedness: 'signed char' to 'uint32_t' (aka 'unsigned int') [-Wsign-conversion]
  uint32_t x = b;
           ~   ^
third_party/fiat/curve25519.c(764,10): warning: implicit conversion loses integer precision: 'uint32_t' (aka 'unsigned int') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  return x;
  ~~~~~~ ^
third_party/fiat/curve25519.c(770,20): warning: implicit conversion loses integer precision: 'int' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  uint8_t babs = b - ((uint8_t)((-bnegative) & b) << 1);
          ~~~~   ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
third_party/fiat/curve25519.c(773,41): warning: implicit conversion changes signedness: 'uint8_t' (aka 'unsigned char') to 'signed char' [-Wsign-conversion]
  cmov(t, &k25519Precomp[pos][0], equal(babs, 1));
                                  ~~~~~ ^~~~
third_party/fiat/curve25519.c(774,41): warning: implicit conversion changes signedness: 'uint8_t' (aka 'unsigned char') to 'signed char' [-Wsign-conversion]
  cmov(t, &k25519Precomp[pos][1], equal(babs, 2));
                                  ~~~~~ ^~~~
third_party/fiat/curve25519.c(775,41): warning: implicit conversion changes signedness: 'uint8_t' (aka 'unsigned char') to 'signed char' [-Wsign-conversion]
  cmov(t, &k25519Precomp[pos][2], equal(babs, 3));
                                  ~~~~~ ^~~~
third_party/fiat/curve25519.c(776,41): warning: implicit conversion changes signedness: 'uint8_t' (aka 'unsigned char') to 'signed char' [-Wsign-conversion]
  cmov(t, &k25519Precomp[pos][3], equal(babs, 4));
                                  ~~~~~ ^~~~
third_party/fiat/curve25519.c(777,41): warning: implicit conversion changes signedness: 'uint8_t' (aka 'unsigned char') to 'signed char' [-Wsign-conversion]
  cmov(t, &k25519Precomp[pos][4], equal(babs, 5));
                                  ~~~~~ ^~~~
third_party/fiat/curve25519.c(778,41): warning: implicit conversion changes signedness: 'uint8_t' (aka 'unsigned char') to 'signed char' [-Wsign-conversion]
  cmov(t, &k25519Precomp[pos][5], equal(babs, 6));
                                  ~~~~~ ^~~~
third_party/fiat/curve25519.c(779,41): warning: implicit conversion changes signedness: 'uint8_t' (aka 'unsigned char') to 'signed char' [-Wsign-conversion]
  cmov(t, &k25519Precomp[pos][6], equal(babs, 7));
                                  ~~~~~ ^~~~
third_party/fiat/curve25519.c(780,41): warning: implicit conversion changes signedness: 'uint8_t' (aka 'unsigned char') to 'signed char' [-Wsign-conversion]
  cmov(t, &k25519Precomp[pos][7], equal(babs, 8));
                                  ~~~~~ ^~~~
third_party/fiat/curve25519.c(798,6): warning: no previous prototype for function 'GFp_x25519_ge_scalarmult_base' [-Wmissing-prototypes]
void GFp_x25519_ge_scalarmult_base(ge_p3 *h, const uint8_t *a) {
     ^
third_party/fiat/curve25519.c(1270,13): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[0] = s0 >> 0;
       ~ ~~~^~~~
third_party/fiat/curve25519.c(1271,13): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[1] = s0 >> 8;
       ~ ~~~^~~~
third_party/fiat/curve25519.c(1272,21): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[2] = (s0 >> 16) | (s1 << 5);
       ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1273,13): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[3] = s1 >> 3;
       ~ ~~~^~~~
third_party/fiat/curve25519.c(1274,13): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[4] = s1 >> 11;
       ~ ~~~^~~~~
third_party/fiat/curve25519.c(1275,21): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[5] = (s1 >> 19) | (s2 << 2);
       ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1276,13): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[6] = s2 >> 6;
       ~ ~~~^~~~
third_party/fiat/curve25519.c(1277,21): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[7] = (s2 >> 14) | (s3 << 7);
       ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1278,13): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[8] = s3 >> 1;
       ~ ~~~^~~~
third_party/fiat/curve25519.c(1279,13): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[9] = s3 >> 9;
       ~ ~~~^~~~
third_party/fiat/curve25519.c(1280,22): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[10] = (s3 >> 17) | (s4 << 4);
        ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1281,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[11] = s4 >> 4;
        ~ ~~~^~~~
third_party/fiat/curve25519.c(1282,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[12] = s4 >> 12;
        ~ ~~~^~~~~
third_party/fiat/curve25519.c(1283,22): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[13] = (s4 >> 20) | (s5 << 1);
        ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1284,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[14] = s5 >> 7;
        ~ ~~~^~~~
third_party/fiat/curve25519.c(1285,22): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[15] = (s5 >> 15) | (s6 << 6);
        ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1286,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[16] = s6 >> 2;
        ~ ~~~^~~~
third_party/fiat/curve25519.c(1287,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[17] = s6 >> 10;
        ~ ~~~^~~~~
third_party/fiat/curve25519.c(1288,22): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[18] = (s6 >> 18) | (s7 << 3);
        ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1289,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[19] = s7 >> 5;
        ~ ~~~^~~~
third_party/fiat/curve25519.c(1290,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[20] = s7 >> 13;
        ~ ~~~^~~~~
third_party/fiat/curve25519.c(1291,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[21] = s8 >> 0;
        ~ ~~~^~~~
third_party/fiat/curve25519.c(1292,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[22] = s8 >> 8;
        ~ ~~~^~~~
third_party/fiat/curve25519.c(1293,22): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[23] = (s8 >> 16) | (s9 << 5);
        ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1294,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[24] = s9 >> 3;
        ~ ~~~^~~~
third_party/fiat/curve25519.c(1295,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[25] = s9 >> 11;
        ~ ~~~^~~~~
third_party/fiat/curve25519.c(1296,22): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[26] = (s9 >> 19) | (s10 << 2);
        ~ ~~~~~~~~~~~^~~~~~~~~~~~
third_party/fiat/curve25519.c(1297,15): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[27] = s10 >> 6;
        ~ ~~~~^~~~
third_party/fiat/curve25519.c(1298,23): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[28] = (s10 >> 14) | (s11 << 7);
        ~ ~~~~~~~~~~~~^~~~~~~~~~~~
third_party/fiat/curve25519.c(1299,15): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[29] = s11 >> 1;
        ~ ~~~~^~~~
third_party/fiat/curve25519.c(1300,15): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[30] = s11 >> 9;
        ~ ~~~~^~~~
third_party/fiat/curve25519.c(1301,15): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[31] = s11 >> 17;
        ~ ~~~~^~~~~
third_party/fiat/curve25519.c(971,6): warning: no previous prototype for function 'GFp_x25519_sc_reduce' [-Wmissing-prototypes]
void GFp_x25519_sc_reduce(uint8_t s[64]) {
     ^
third_party/fiat/curve25519.c(1759,13): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[0] = s0 >> 0;
       ~ ~~~^~~~
third_party/fiat/curve25519.c(1760,13): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[1] = s0 >> 8;
       ~ ~~~^~~~
third_party/fiat/curve25519.c(1761,21): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[2] = (s0 >> 16) | (s1 << 5);
       ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1762,13): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[3] = s1 >> 3;
       ~ ~~~^~~~
third_party/fiat/curve25519.c(1763,13): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[4] = s1 >> 11;
       ~ ~~~^~~~~
third_party/fiat/curve25519.c(1764,21): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[5] = (s1 >> 19) | (s2 << 2);
       ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1765,13): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[6] = s2 >> 6;
       ~ ~~~^~~~
third_party/fiat/curve25519.c(1766,21): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[7] = (s2 >> 14) | (s3 << 7);
       ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1767,13): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[8] = s3 >> 1;
       ~ ~~~^~~~
third_party/fiat/curve25519.c(1768,13): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[9] = s3 >> 9;
       ~ ~~~^~~~
third_party/fiat/curve25519.c(1769,22): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[10] = (s3 >> 17) | (s4 << 4);
        ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1770,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[11] = s4 >> 4;
        ~ ~~~^~~~
third_party/fiat/curve25519.c(1771,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[12] = s4 >> 12;
        ~ ~~~^~~~~
third_party/fiat/curve25519.c(1772,22): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[13] = (s4 >> 20) | (s5 << 1);
        ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1773,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[14] = s5 >> 7;
        ~ ~~~^~~~
third_party/fiat/curve25519.c(1774,22): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[15] = (s5 >> 15) | (s6 << 6);
        ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1775,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[16] = s6 >> 2;
        ~ ~~~^~~~
third_party/fiat/curve25519.c(1776,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[17] = s6 >> 10;
        ~ ~~~^~~~~
third_party/fiat/curve25519.c(1777,22): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[18] = (s6 >> 18) | (s7 << 3);
        ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1778,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[19] = s7 >> 5;
        ~ ~~~^~~~
third_party/fiat/curve25519.c(1779,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[20] = s7 >> 13;
        ~ ~~~^~~~~
third_party/fiat/curve25519.c(1780,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[21] = s8 >> 0;
        ~ ~~~^~~~
third_party/fiat/curve25519.c(1781,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[22] = s8 >> 8;
        ~ ~~~^~~~
third_party/fiat/curve25519.c(1782,22): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[23] = (s8 >> 16) | (s9 << 5);
        ~ ~~~~~~~~~~~^~~~~~~~~~~
third_party/fiat/curve25519.c(1783,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[24] = s9 >> 3;
        ~ ~~~^~~~
third_party/fiat/curve25519.c(1784,14): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[25] = s9 >> 11;
        ~ ~~~^~~~~
third_party/fiat/curve25519.c(1785,22): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[26] = (s9 >> 19) | (s10 << 2);
        ~ ~~~~~~~~~~~^~~~~~~~~~~~
third_party/fiat/curve25519.c(1786,15): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[27] = s10 >> 6;
        ~ ~~~~^~~~
third_party/fiat/curve25519.c(1787,23): warning: implicit conversion loses integer precision: 'long long' to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[28] = (s10 >> 14) | (s11 << 7);
        ~ ~~~~~~~~~~~~^~~~~~~~~~~~
third_party/fiat/curve25519.c(1788,15): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[29] = s11 >> 1;
        ~ ~~~~^~~~
third_party/fiat/curve25519.c(1789,15): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[30] = s11 >> 9;
        ~ ~~~~^~~~
third_party/fiat/curve25519.c(1790,15): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'uint8_t' (aka 'unsigned char') [-Wimplicit-int-conversion]
  s[31] = s11 >> 17;
        ~ ~~~~^~~~~
third_party/fiat/curve25519.c(1794,6): warning: no previous prototype for function 'GFp_x25519_scalar_mult_generic_masked' [-Wmissing-prototypes]
void GFp_x25519_scalar_mult_generic_masked(uint8_t out[32],
     ^
third_party/fiat/curve25519.c(1872,6): warning: no previous prototype for function 'GFp_x25519_public_from_private_generic_masked' [-Wmissing-prototypes]
void GFp_x25519_public_from_private_generic_masked(uint8_t out_public_value[32],
     ^
third_party/fiat/curve25519.c(1891,6): warning: no previous prototype for function 'GFp_x25519_fe_invert' [-Wmissing-prototypes]
void GFp_x25519_fe_invert(fe *out, const fe *z) {
     ^
third_party/fiat/curve25519.c(1895,9): warning: no previous prototype for function 'GFp_x25519_fe_isnegative' [-Wmissing-prototypes]
uint8_t GFp_x25519_fe_isnegative(const fe *f) {
        ^
third_party/fiat/curve25519.c(1899,6): warning: no previous prototype for function 'GFp_x25519_fe_mul_ttt' [-Wmissing-prototypes]
void GFp_x25519_fe_mul_ttt(fe *h, const fe *f, const fe *g) {
     ^
third_party/fiat/curve25519.c(1903,6): warning: no previous prototype for function 'GFp_x25519_fe_neg' [-Wmissing-prototypes]
void GFp_x25519_fe_neg(fe *f) {
     ^
third_party/fiat/curve25519.c(1909,6): warning: no previous prototype for function 'GFp_x25519_fe_tobytes' [-Wmissing-prototypes]
void GFp_x25519_fe_tobytes(uint8_t s[32], const fe *h) {
     ^
third_party/fiat/curve25519.c(1913,6): warning: no previous prototype for function 'GFp_x25519_ge_double_scalarmult_vartime' [-Wmissing-prototypes]
void GFp_x25519_ge_double_scalarmult_vartime(ge_p2 *r, const uint8_t *a,
     ^
third_party/fiat/curve25519.c(1918,6): warning: no previous prototype for function 'GFp_x25519_sc_mask' [-Wmissing-prototypes]
void GFp_x25519_sc_mask(uint8_t a[32]) {
     ^
third_party/fiat/curve25519.c(1924,6): warning: no previous prototype for function 'GFp_x25519_sc_muladd' [-Wmissing-prototypes]
void GFp_x25519_sc_muladd(uint8_t *s, const uint8_t *a, const uint8_t *b,
     ^
94 warnings generated.
thread 'main' panicked at '"C:\\Users\\task_1584958359\\.cargo\\registry\\src\\github.com-1ecc6299db9ec823\\ring-0.16.11\\pregenerated\\aesv8-armx-linux64.obj": Os { code: 2, kind: NotFound, message: "The system cannot find the file specified." }', C:\Users\task_1584958359\.cargo\registry\src\github.com-1ecc6299db9ec823\ring-0.16.11\build.rs:753:5
stack backtrace:
   0: std::sys_common::backtrace::_print::{{impl}}::fmt
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\/src\libstd\sys_common\backtrace.rs:59
   1: core::fmt::write
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\/src\libcore\fmt\mod.rs:1069
   2: std::io::Write::write_fmt<std::sys::windows::stdio::Stderr>
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\/src\libstd\io\mod.rs:1427
   3: std::panicking::default_hook::{{closure}}
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\/src\libstd\panicking.rs:198
   4: std::panicking::default_hook
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\/src\libstd\panicking.rs:218
   5: std::panicking::rust_panic_with_hook
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\/src\libstd\panicking.rs:509
   6: std::panicking::begin_panic_handler
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\/src\libstd\panicking.rs:417
   7: core::panicking::panic_fmt
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\/src\libcore\panicking.rs:111
   8: core::option::expect_none_failed
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\/src\libcore\option.rs:1211
   9: core::result::Result<std::fs::Metadata, std::io::error::Error>::expect<std::fs::Metadata,std::io::error::Error>
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\src\libcore\result.rs:961
  10: build_script_build::file_modified
             at .\build.rs:753
  11: build_script_build::need_run
             at .\build.rs:739
  12: build_script_build::build_library::{{closure}}
             at .\build.rs:461
  13: core::iter::traits::iterator::Iterator::any::check::{{closure}}<std::path::Path*,closure-2>
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\src\libcore\iter\traits\iterator.rs:2107
  14: core::iter::adapters::map_try_fold::{{closure}}<alloc::string::String*,std::path::Path*,(),core::iter::LoopState<(), ()>,fn(alloc::string::String*) -> std::path::Path*,closure-0>
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\src\libcore\iter\adapters\mod.rs:791
  15: core::iter::traits::iterator::Iterator::try_fold<core::slice::Iter<alloc::string::String>,(),closure-0,core::iter::LoopState<(), ()>>
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\src\libcore\iter\traits\iterator.rs:1877
  16: core::iter::adapters::{{impl}}::try_fold<std::path::Path*,core::slice::Iter<alloc::string::String>,fn(alloc::string::String*) -> std::path::Path*,(),closure-0,core::iter::LoopState<(), ()>>
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\src\libcore\iter\adapters\mod.rs:817
  17: core::iter::traits::iterator::Iterator::any<core::iter::adapters::Map<core::slice::Iter<alloc::string::String>, fn(alloc::string::String*) -> std::path::Path*>,closure-2>
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\src\libcore\iter\traits\iterator.rs:2111
  18: build_script_build::build_library
             at .\build.rs:458
  19: build_script_build::build_c_code::{{closure}}
             at .\build.rs:421
  20: core::iter::traits::iterator::Iterator::for_each::call::{{closure}}<(str*, slice<std::path::PathBuf>*, slice<std::path::PathBuf>*)*,closure-4>
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\src\libcore\iter\traits\iterator.rs:655
  21: core::iter::traits::iterator::Iterator::fold::ok::{{closure}}<(),(str*, slice<std::path::PathBuf>*, slice<std::path::PathBuf>*)*,closure-0>
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\src\libcore\iter\traits\iterator.rs:2001
  22: core::iter::traits::iterator::Iterator::try_fold<core::slice::Iter<(str*, slice<std::path::PathBuf>*, slice<std::path::PathBuf>*)>,(),closure-0,core::result::Result<(), !>>
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\src\libcore\iter\traits\iterator.rs:1877
  23: core::iter::traits::iterator::Iterator::fold<core::slice::Iter<(str*, slice<std::path::PathBuf>*, slice<std::path::PathBuf>*)>,(),closure-0>
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\src\libcore\iter\traits\iterator.rs:2004
  24: core::iter::traits::iterator::Iterator::for_each<core::slice::Iter<(str*, slice<std::path::PathBuf>*, slice<std::path::PathBuf>*)>,closure-4>
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\src\libcore\iter\traits\iterator.rs:658
  25: build_script_build::build_c_code
             at .\build.rs:420
  26: build_script_build::ring_build_rs_main
             at .\build.rs:295
  27: build_script_build::main
             at .\build.rs:252
  28: std::rt::lang_start::{{closure}}<()>
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\src\libstd\rt.rs:67
  29: std::rt::lang_start_internal
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\/src\libstd\rt.rs:51
  30: std::rt::lang_start<()>
             at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb\src\libstd\rt.rs:67
  31: main
  32: __scrt_common_main_seh
             at d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
  33: BaseThreadInitThunk
  34: RtlUserThreadStart
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
@jdm
Copy link
Member Author

jdm commented Mar 23, 2020

It's very relevant - looks like the build script for ring for ARM64 windows needs fixing.
@nox
Copy link
Member

nox commented Mar 23, 2020

This says that those files are pre-generated: https://github.com/briansmith/ring/blob/ddfa683266e8ce41c06feb9f46503dd4e1d47ab1/build.rs#L394-L404

Seems like someone needs to generate them files for the UWP targets we care about.
@nox
Copy link
Member

nox commented Mar 23, 2020 

± curl -s https://static.crates.io/crates/ring/ring-0.16.11.crate | tar tf - | grep obj$
ring-0.16.11/pregenerated/aes-586-win32n.obj
ring-0.16.11/pregenerated/aes-x86_64-nasm.obj
ring-0.16.11/pregenerated/aesni-gcm-x86_64-nasm.obj
ring-0.16.11/pregenerated/aesni-x86-win32n.obj
ring-0.16.11/pregenerated/aesni-x86_64-nasm.obj
ring-0.16.11/pregenerated/chacha-x86-win32n.obj
ring-0.16.11/pregenerated/chacha-x86_64-nasm.obj
ring-0.16.11/pregenerated/ecp_nistz256-x86-win32n.obj
ring-0.16.11/pregenerated/ghash-x86-win32n.obj
ring-0.16.11/pregenerated/ghash-x86_64-nasm.obj
ring-0.16.11/pregenerated/p256-x86_64-asm-nasm.obj
ring-0.16.11/pregenerated/poly1305-x86-win32n.obj
ring-0.16.11/pregenerated/poly1305-x86_64-nasm.obj
ring-0.16.11/pregenerated/sha256-x86_64-nasm.obj
ring-0.16.11/pregenerated/sha512-x86_64-nasm.obj
ring-0.16.11/pregenerated/vpaes-x86-win32n.obj
ring-0.16.11/pregenerated/vpaes-x86_64-nasm.obj
ring-0.16.11/pregenerated/x86-mont-win32n.obj
ring-0.16.11/pregenerated/x86_64-mont-nasm.obj
ring-0.16.11/pregenerated/x86_64-mont5-nasm.obj
@Darkspirit Darkspirit mentioned this pull request Mar 23, 2020
Open
@jdm
Copy link
Member Author

jdm commented Mar 23, 2020

Submitted rust-ammonia/rust-content-security-policy#28 to avoid the arm64 windows build issue.
@jdm
Update content-security-policy.
Loading status checks…
1921662
@jdm jdm force-pushed the jdm:hubs-csp branch from ad1bec1 to 1921662 Mar 25, 2020
@jdm
Copy link
Member Author

jdm commented Mar 25, 2020

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2020

📌 Commit 1921662 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2020

⌛ Testing commit 1921662 with merge 0f09d70...
bors-servo added a commit that referenced this pull request Mar 25, 2020
@bors-servo
Auto merge of #26005 - jdm:hubs-csp, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0f09d70 
Update content-security-policy.

This allows hubs.mozilla.org to load instead of panicking due to unimplemented CSP features.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24702
- [x] These changes do not require tests because we never enabled the CSP testsuite
@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Mar 25, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2020

⌛ Testing commit 1921662 with merge 9e8a99d...
bors-servo added a commit that referenced this pull request Mar 25, 2020
@bors-servo
Auto merge of #26005 - jdm:hubs-csp, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9e8a99d 
Update content-security-policy.

This allows hubs.mozilla.org to load instead of panicking due to unimplemented CSP features.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24702
- [x] These changes do not require tests because we never enabled the CSP testsuite
@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Mar 25, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2020

⌛ Testing commit 1921662 with merge a9965db...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing a9965db to master...
@bors-servo bors-servo merged commit a9965db into servo:master Mar 25, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Mar 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nox nox

Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Hubs panics during CSP calculation
6 participants
@jdm @highfive @nox @bors-servo @CYBAI @asajeffrey
You can’t perform that action at this time.