Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemoved createTouch and createTouchList #26017
Merged
Conversation
highfive
commented
Mar 23, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Mar 23, 2020
|
|
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Mar 23, 2020
Removed createTouch and createTouchList <!-- Please describe your changes on the following line: --> One thing I need to ask is that do these also needs to be removed from `/tests/wpt/web-platform-tests/touch-events/historical.html` & `tests/wpt/webgl/tests/deqp/temp_externs/iphone.js`? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25978 <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
We correctly pass the test that verifies that these APIs don't exist now: Please update the test results for these tests in tests/wpt/metadata/touch-events/historical.html.ini! |
| [Document::createTouch] | ||
| expected: FAIL |
Comment on lines
14
to
15
This comment has been minimized.
This comment has been minimized.
|
|
||
| [TouchList::identifiedTouch] | ||
| expected: FAIL | ||
|
|
||
| [Document::createTouchList] | ||
| expected: FAIL | ||
| expected: PASS |
This comment has been minimized.
This comment has been minimized.
|
@jdm Can you have a look at it now? |
|
Looks good! Please squash them into a single commit and we'll merge them! |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 23, 2020
Removed createTouch and createTouchList <!-- Please describe your changes on the following line: --> One thing I need to ask is that do these also needs to be removed from `/tests/wpt/web-platform-tests/touch-events/historical.html` & `tests/wpt/webgl/tests/deqp/temp_externs/iphone.js`? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25978 <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Mar 24, 2020
Removed createTouch and createTouchList <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25978 <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Mar 24, 2020
Removed createTouch and createTouchList <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25978 <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
humancalico commentedMar 23, 2020
•
edited
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors