Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert fillText() #26021

Merged
merged 1 commit into from Mar 24, 2020
Merged

Revert fillText() #26021

merged 1 commit into from Mar 24, 2020

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Mar 24, 2020

Sadly, fillText crashes our HoloLens demos. See #26015

/cc @kaiakz
@paulrouget
Revert "Add a simple implementation of CanvasRenderingContext2d.fillT…
Loading status checks…
40f6cd8 
…ext"

Windows crash: #26015
@paulrouget paulrouget force-pushed the paulrouget:revertFillText branch from 639b7e1 to 40f6cd8 Mar 24, 2020
@jdm
Copy link
Member

jdm commented Mar 24, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2020

📌 Commit 40f6cd8 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2020

⌛ Testing commit 40f6cd8 with merge 4f5110f...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 4f5110f to master...
@bors-servo bors-servo merged commit 4f5110f into servo:master Mar 24, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@paulrouget @jdm @bors-servo @highfive
You can’t perform that action at this time.