Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate backtrace to 0.3.46 #26024
Closed
Update backtrace to 0.3.46 #26024
Conversation
highfive
commented
Mar 24, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Mar 24, 2020
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 24, 2020
Update backtrace to 0.3.46 rust-lang/backtrace-rs#299 landed so we can stop patching backtrace in our tree.
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Mar 25, 2020
Update backtrace to 0.3.46 rust-lang/backtrace-rs#299 landed so we can stop patching backtrace in our tree.
|
|
|
Looks like we now actually pick up the panics from #25838 correctly? |
|
Sorry I fail to connect your comment and the linked issue to the failures. Do you mean that those new timeouts and whatnot are good news? |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Mar 25, 2020
Update backtrace to 0.3.46 rust-lang/backtrace-rs#299 landed so we can stop patching backtrace in our tree.
|
|
Looks like sadly yes? |
|
I'm not sad about that - it means that we're actually reporting real results from those tests now. |
|
Specifically, we've seen these panics intermittently in the past: #25258 |
|
@jdm So I should just update the expectations and be done with it? |
|
I would say yes. |
|
So for the failures in "Servo: macOS x64: WPT chunk 06 / 20", in the first round we got:
In the second, we got:
So yes it is consistent that there are panics and whatnot, but the failures themselves are all intermittent and I want to cry. Many of them I couldn't reproduce locally and sometimes I got TIMEOUT instead of CRASH. |
|
|
|
It just occurred to me that I once again didn't look at the right section in the test results, so disregard that. |
|
Actually the new backtrace version should be able to load more debugging symbols than my fork, but it shouldn't "see" new panics, I think. But then there were more changes to backtrace, so the only way to really verify this is by looking at the individual issues and checking if they are correct fails. Anyway: This Fixes #24984, don't forget to close the issue once this is merged. |
bors-servo
added a commit
that referenced
this pull request
Apr 23, 2020
bors-servo
added a commit
that referenced
this pull request
Apr 25, 2020
Some Cargo.toml cleanups <!-- Please describe your changes on the following line: --> Some Cargo.toml cleanups. Adapted from #26024. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Apr 25, 2020
Some Cargo.toml cleanups <!-- Please describe your changes on the following line: --> Some Cargo.toml cleanups. Adapted from #26024. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedMar 24, 2020
rust-lang/backtrace-rs#299 landed so we can stop patching backtrace in our tree.