Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSet user interactions for tasks #26029
Merged
Conversation
highfive
commented
Mar 25, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Mar 25, 2020
|
There's a null promise object being passed in enqueue_promise_job. I'm doing a debugmozjs build to try to figure out why. |
|
@paulrouget Judging by gecko and spidermonkey code, passing a null promise object is a valid state so I pushed a change that avoids the crash. I can successfully start immersive mode in the tennis demo on desktop now. |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Mar 26, 2020
Set user interactions for tasks fix #26026 I need help here. Retrieving the interaction flag from the promise handle crashes. ```rust let interaction = GetPromiseUserInputEventHandlingState(promise); ``` ``` Stack trace for thread "ScriptThread PipelineId { namespace_id: PipelineNamespaceId(1), index: PipelineIndex(1) }" stack backtrace: 0: backtrace::backtrace::libunwind::trace at /Users/paul/.cargo/git/checkouts/backtrace-rs-96ebaf1bcb788384/91a0aa4/src/backtrace/libunwind.rs:86 backtrace::backtrace::trace_unsynchronized at /Users/paul/.cargo/git/checkouts/backtrace-rs-96ebaf1bcb788384/91a0aa4/src/backtrace/mod.rs:66 1: <servo::backtrace::Print as core::fmt::Debug>::fmt at ports/glutin/backtrace.rs:49 2: <&mut W as core::fmt::Write>::write_fmt 3: std::io::Write::write_fmt at /rustc/45ebd5808afd3df7ba842797c0fcd4447ddf30fb/src/libstd/io/mod.rs:1427 4: servo::backtrace::print at ports/glutin/backtrace.rs:17 5: servo::install_crash_handler::handler at ports/glutin/main2.rs:68 6: <unknown> 7: _ZN2JS37GetPromiseUserInputEventHandlingStateENS_6HandleIP8JSObjectEE at /Users/paul/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/2392ebc/mozjs/js/src/vm/JSObject.h:106 ```
|
|
|
@jdm r? |
|
@bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedMar 25, 2020
fix #26026
I need help here. Retrieving the interaction flag from the promise handle crashes.