Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rust-mozjs exposed function to generate SourceText #26038

Merged
merged 1 commit into from Mar 31, 2020
Merged

Use rust-mozjs exposed function to generate SourceText #26038

merged 1 commit into from Mar 31, 2020

Conversation

@CYBAI
Copy link
Collaborator

CYBAI commented Mar 26, 2020

With the exposed functions from mozjs, we can get rid of the get_source_text in script_module.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because it just tries to use exposed functions from mozjs to create SourceText
@highfive
Copy link

highfive commented Mar 26, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/globalscope.rs, components/script/script_module.rs, components/script/dom/eventtarget.rs
  • @KiChjang: components/script/dom/globalscope.rs, components/script/script_module.rs, components/script/dom/eventtarget.rs
@highfive
Copy link

highfive commented Mar 26, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@CYBAI
Copy link
Collaborator Author

CYBAI commented Mar 26, 2020

r? @nox
@highfive highfive assigned nox and unassigned paulrouget Mar 26, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

☔ The latest upstream changes (presumably #26062) made this pull request unmergeable. Please resolve the merge conflicts.
@CYBAI CYBAI force-pushed the CYBAI:mozjs-sourcetext branch from 5fe51b3 to f65e615 Mar 31, 2020
@CYBAI CYBAI removed the S-needs-rebase label Mar 31, 2020
@CYBAI
Copy link
Collaborator Author

CYBAI commented Mar 31, 2020

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Mar 31, 2020
@bors-servo
Auto merge of #26038 - CYBAI:mozjs-sourcetext, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dceb23c 
Use rust-mozjs exposed function to generate SourceText

With the exposed functions from mozjs, we can get rid of the `get_source_text` in `script_module`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it just tries to use exposed functions from mozjs to create `SourceText`

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

⌛ Trying commit f65e615 with merge dceb23c...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@jdm
jdm approved these changes Mar 31, 2020
View changes
Copy link
Member

jdm left a comment

Needs a mach fmt.
@CYBAI
Use mozjs exposed function to generate SourceText
Loading status checks…
018b23d
@CYBAI CYBAI force-pushed the CYBAI:mozjs-sourcetext branch from f65e615 to 018b23d Mar 31, 2020
@CYBAI
Copy link
Collaborator Author

CYBAI commented Mar 31, 2020

Thanks! Totally didn't notice the fmt error! Updated!
@jdm
Copy link
Member

jdm commented Mar 31, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

📌 Commit 018b23d has been approved by jdm
@highfive highfive assigned jdm and unassigned nox Mar 31, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

⌛ Testing commit 018b23d with merge 0927182...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 0927182 to master...
@bors-servo bors-servo merged commit 0927182 into servo:master Mar 31, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@CYBAI CYBAI deleted the CYBAI:mozjs-sourcetext branch Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@CYBAI @highfive @bors-servo @jdm @nox @paulrouget
You can’t perform that action at this time.