servo / servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu API #26043

Merged

bors-servo merged 2 commits into servo:master from paulrouget:IMMenu

Mar 30, 2020

Contributor

paulrouget commented Mar 27, 2020

This adds an API for Servo internals to request a context menu to the embedder, along an implement for the UWP port.

highfive assigned nox

highfive added the S-awaiting-review label

paulrouget force-pushed the paulrouget:IMMenu branch from 662be33 to 410f917

paulrouget mentioned this pull request

Immersive "app" menu on hololens #25797

Closed

Member

jdm commented Mar 27, 2020

error[E0004]: non-exhaustive patterns: `ShowContextMenu(_, _)` not covered
   --> ports/glutin/browser.rs:280:19
    |
280 |             match msg {
    |                   ^^^ pattern `ShowContextMenu(_, _)` not covered
    |
    = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
error: aborting due to previous error

jdm approved these changes

ports/libsimpleservo/capi/src/lib.rs Outdated

  
                    .collect();

                let ptrs: Vec<*const c_char> = cstrs.iter().map(|cstr| cstr.as_ptr()).collect();

                (self.0.show_context_menu)(ptrs.as_ptr(), size);

                let _ = cstrs; // Don't drop these too early

jdm Mar 27, 2020

Member

This line doesn't look like it should actually be necessary - won't cstrs last until the end of function by default?

paulrouget Mar 30, 2020

Author Contributor

Hmm… I tried again, and indeed cstrs is not dropped early.
For some reason this was necessary at some point, not sure why.

I removed the line.

jdm assigned jdm and unassigned nox

jdm added S-needs-code-changes and removed S-awaiting-review labels

Manishearth mentioned this pull request

Hook up new openxr context menu gesture to embedder context menu machinery #26051

Merged

paulrouget force-pushed the paulrouget:IMMenu branch from 410f917 to 2d40bdf

highfive added S-awaiting-review and removed S-needs-code-changes labels

Contributor Author

paulrouget commented Mar 30, 2020

@bors-servo r=jdm

Contributor

bors-servo commented Mar 30, 2020

📌 Commit 2d40bdf has been approved by jdm

highfive added S-awaiting-merge and removed S-awaiting-review labels

Contributor

bors-servo commented Mar 30, 2020

⌛ Testing commit 2d40bdf with merge 9811964...

bors-servo added a commit that referenced this pull request


        Auto merge of #26043 - paulrouget:IMMenu, r=jdm

Context menu API

This adds an API for Servo internals to request a context menu to the embedder, along an implement for the UWP port.

paulrouget force-pushed the paulrouget:IMMenu branch from 2d40bdf to 499393d

highfive added S-awaiting-review and removed S-awaiting-merge labels

paulrouget added 2 commits


        Context Menu: API

ed46f59


        Context Menu: UWP

ed601bc

paulrouget force-pushed the paulrouget:IMMenu branch from 499393d to ed601bc

Contributor Author

paulrouget commented Mar 30, 2020

@bors-servo r=jdm

Contributor

bors-servo commented Mar 30, 2020

📌 Commit ed601bc has been approved by jdm

highfive added S-awaiting-merge and removed S-awaiting-review labels

Contributor

bors-servo commented Mar 30, 2020

⌛ Testing commit ed601bc with merge ded381c...

bors-servo added a commit that referenced this pull request


        Auto merge of #26043 - paulrouget:IMMenu, r=jdm

ded381c

Context menu API

This adds an API for Servo internals to request a context menu to the embedder, along an implement for the UWP port.

Contributor

bors-servo commented Mar 30, 2020

💔 Test failed - status-taskcluster

highfive added S-tests-failed and removed S-awaiting-merge labels

Contributor Author

paulrouget commented Mar 30, 2020

@bors-servo retry

#24355

bors-servo added a commit that referenced this pull request


        Auto merge of #26043 - paulrouget:IMMenu, r=jdm

b12337a

Context menu API

This adds an API for Servo internals to request a context menu to the embedder, along an implement for the UWP port.

Contributor

bors-servo commented Mar 30, 2020

⌛ Testing commit ed601bc with merge b12337a...

highfive added S-awaiting-merge and removed S-tests-failed labels

Contributor

bors-servo commented Mar 30, 2020

💔 Test failed - status-taskcluster

highfive added S-tests-failed and removed S-awaiting-merge labels

Collaborator

CYBAI commented Mar 30, 2020

@bors-servo retry

#25513

Contributor

bors-servo commented Mar 30, 2020

⌛ Testing commit ed601bc with merge c3ecf2e...

highfive added S-awaiting-merge and removed S-tests-failed labels

Contributor

bors-servo commented Mar 30, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing c3ecf2e to master...

bors-servo merged commit c3ecf2e into servo:master

2 checks passed

2 checks passed

Community-TC (pull_request) TaskGroup: success

Details

homu Test successful

Details

highfive removed the S-awaiting-merge label

bors-servo added a commit that referenced this pull request


        Auto merge of #26051 - Manishearth:openxr-context, r=jdm

b1fcdec

Hook up new openxr context menu gesture to embedder context menu machinery

Based on #26043

Fixes #25797, #26057

servo/webxr#144 needs to land first

Currently when exited the Servo window is blurred, apparently we need to call `Window.Activate` on it.

r? @jdm

cc @paulrouget

bors-servo added a commit that referenced this pull request


        Auto merge of #26051 - Manishearth:openxr-context, r=jdm

955d1ed

Hook up new openxr context menu gesture to embedder context menu machinery

Based on #26043

Fixes #25797, #26057

servo/webxr#144 needs to land first

Currently when exited the Servo window is blurred, apparently we need to call `Window.Activate` on it.

r? @jdm

cc @paulrouget

bors-servo added a commit that referenced this pull request


        Auto merge of #26051 - Manishearth:openxr-context, r=jdm

7e45929

Hook up new openxr context menu gesture to embedder context menu machinery

Based on #26043

Fixes #25797, #26057

servo/webxr#144 needs to land first

Currently when exited the Servo window is blurred, apparently we need to call `Window.Activate` on it.

r? @jdm

cc @paulrouget

bors-servo added a commit that referenced this pull request


        Auto merge of #26051 - Manishearth:openxr-context, r=jdm

1c9191f

Hook up new openxr context menu gesture to embedder context menu machinery

Based on #26043

Fixes #25797, #26057

servo/webxr#144 needs to land first

Currently when exited the Servo window is blurred, apparently we need to call `Window.Activate` on it.

r? @jdm

cc @paulrouget

bors-servo added a commit that referenced this pull request


        Auto merge of #26051 - Manishearth:openxr-context, r=jdm

7e31a66

Hook up new openxr context menu gesture to embedder context menu machinery

Based on #26043

Fixes #25797, #26057

servo/webxr#144 needs to land first

Currently when exited the Servo window is blurred, apparently we need to call `Window.Activate` on it.

r? @jdm

cc @paulrouget

bors-servo added a commit that referenced this pull request


        Auto merge of #26051 - Manishearth:openxr-context, r=jdm

b3c12ad

Hook up new openxr context menu gesture to embedder context menu machinery

Based on #26043

Fixes #25797, #26057

servo/webxr#144 needs to land first

Currently when exited the Servo window is blurred, apparently we need to call `Window.Activate` on it.

r? @jdm

cc @paulrouget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.