Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Atomics.wait in a dedicated worker agent #26056

Merged

Conversation

@gterzian
Copy link
Member

gterzian commented Mar 30, 2020

FIX #25191


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented Mar 30, 2020

Heads up! This PR modifies the following files:

@gterzian gterzian changed the title Wnable Atomics.wait in a dedicated worker agent Enable Atomics.wait in a dedicated worker agent Mar 30, 2020
@gterzian gterzian force-pushed the gterzian:enable_atomics_wait_on_dedicated_worker branch from b56f4bb to 8d640f0 Mar 30, 2020
@gterzian gterzian force-pushed the gterzian:enable_atomics_wait_on_dedicated_worker branch from 8d640f0 to 3ce6109 Mar 30, 2020
@jdm
Copy link
Member

jdm commented Mar 30, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2020

📌 Commit 3ce6109 has been approved by jdm

@highfive highfive assigned jdm and unassigned paulrouget Mar 30, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2020

Testing commit 3ce6109 with merge e3985e5...

bors-servo added a commit that referenced this pull request Mar 30, 2020
…er, r=jdm

Enable Atomics.wait in a dedicated worker agent

<!-- Please describe your changes on the following line: -->

FIX #25191

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Mar 30, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2020

Testing commit 3ce6109 with merge fd6f914...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing fd6f914 to master...

@bors-servo bors-servo merged commit fd6f914 into servo:master Mar 30, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@gterzian gterzian deleted the gterzian:enable_atomics_wait_on_dedicated_worker branch Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.