Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing assertion -- failure to pop reference frame #26063

Merged
merged 1 commit into from Mar 31, 2020
Merged

Fix failing assertion -- failure to pop reference frame #26063

merged 1 commit into from Mar 31, 2020

Conversation

@dralley
Copy link
Contributor

dralley commented Mar 31, 2020 •
edited by cbrewster

closes #23438, closes #22901

In-depth description here: #23438 (comment)

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #23438 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented Mar 31, 2020

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon.
@highfive
Copy link

highfive commented Mar 31, 2020

Heads up! This PR modifies the following files:

  • @emilio: components/layout/display_list/items.rs, components/layout/display_list/webrender_helpers.rs
@highfive
Copy link

highfive commented Mar 31, 2020

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@dralley
Copy link
Contributor Author

dralley commented Mar 31, 2020

Cannot run test-tidy locally because Fedora 31 is Python 3 only
@cbrewster
Copy link
Member

cbrewster commented Mar 31, 2020

LGTM Thanks!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

📌 Commit c1c0346 has been approved by cbrewster
@highfive highfive assigned cbrewster and unassigned SimonSapin Mar 31, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

⌛ Testing commit c1c0346 with merge 2f7de37...
bors-servo added a commit that referenced this pull request Mar 31, 2020
@bors-servo
Auto merge of #26063 - dralley:fix-assertion, r=cbrewster
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2f7de37 
Fix failing assertion -- failure to pop reference frame

closes #23438

In-depth description here: #23438 (comment)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [x] These changes fix #23438 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

💔 Test failed - status-taskcluster
@cbrewster
Copy link
Member

cbrewster commented Mar 31, 2020 •
edited

Looks like a previously failing 3D transform test is now passing!

  ▶ PASS [expected FAIL] /css/compositing/mix-blend-mode/mix-blend-mode-sibling-with-3D-transform.html

Info on updating test expectations: https://github.com/servo/servo/blob/master/tests/wpt/README.md#updating-test-expectations
@dralley
Fix failing assertion -- failure to pop reference frame
Loading status checks…
3258bca 
closes #23438
@dralley dralley force-pushed the dralley:fix-assertion branch from c1c0346 to 3258bca Mar 31, 2020
@cbrewster
Copy link
Member

cbrewster commented Mar 31, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

📌 Commit 3258bca has been approved by cbrewster
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

⌛ Testing commit 3258bca with merge 687156a...
This was referenced Mar 31, 2020
Closed
Closed
@cbrewster
Copy link
Member

cbrewster commented Mar 31, 2020

This will also need fixed for layout_2020, but we can do that in a followup.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

☀️ Test successful - status-taskcluster
Approved by: cbrewster
Pushing 687156a to master...
@bors-servo bors-servo merged commit 687156a into servo:master Mar 31, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@cbrewster cbrewster mentioned this pull request Mar 31, 2020
Closed
@dralley dralley deleted the dralley:fix-assertion branch Mar 31, 2020
@dralley dralley mentioned this pull request Mar 31, 2020
Merged
2 of 5 tasks complete
bors-servo added a commit that referenced this pull request Mar 31, 2020
@bors-servo
Auto merge of #26072 - dralley:fix-assertion-layout2020, r=mrobinson
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4ccbb13 
Ensure reference frame is popped in layout 2020

closes: #26066

Should be equivalent to #26063 for layout2020

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [x] These changes fix #26066 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
bors-servo added a commit that referenced this pull request Mar 31, 2020
@bors-servo
Auto merge of #26072 - dralley:fix-assertion-layout2020, r=mrobinson
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
148c24c 
Ensure reference frame is popped in layout 2020

closes: #26066

Should be equivalent to #26063 for layout2020

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [x] These changes fix #26066 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cbrewster cbrewster

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

assertion failed: child_index.0 >= parent_index.0
"invalid parent" error from WebRender
5 participants
@dralley @highfive @cbrewster @bors-servo @SimonSapin
You can’t perform that action at this time.