Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid infinitely looping CSS transitions. #26074

Merged
merged 1 commit into from Apr 1, 2020
Merged

Avoid infinitely looping CSS transitions. #26074

merged 1 commit into from Apr 1, 2020
+61 −20

Conversation

@jdm
Copy link
Member

jdm commented Mar 31, 2020

This change addresses the long-standing issue of CSS transitions not ending appropriately. It does not fundamentally change the way we process transitions/animations.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #20379
  • There are tests for these changes
@highfive
Copy link

highfive commented Mar 31, 2020

Heads up! This PR modifies the following files:

  • @emilio: components/style/matching.rs, components/style/animation.rs, components/layout/animation.rs
@jdm
Copy link
Member Author

jdm commented Mar 31, 2020

I have verified that all of the test cases from #20379 continue to transition appropriately, and the transition present in the VR button in babylon.js demos works fine with these changes.

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Mar 31, 2020
@bors-servo
Auto merge of #26074 - jdm:transition-fix, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
364dabe 
Avoid infinitely looping CSS transitions.

This change addresses the long-standing issue of CSS transitions not ending appropriately. It does not fundamentally change the way we process transitions/animations.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20379
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

⌛ Trying commit 34709e3 with merge 364dabe...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@jdm jdm added this to In progress in babylon.js perf issues via automation Mar 31, 2020
@jdm jdm added this to In progress in HoloLens Mar 31, 2020
@jdm
Copy link
Member Author

jdm commented Mar 31, 2020

r? @SimonSapin
@SimonSapin
Copy link
Member

SimonSapin commented Apr 1, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

📌 Commit 34709e3 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

⌛ Testing commit 34709e3 with merge d06158a...
bors-servo added a commit that referenced this pull request Apr 1, 2020
@bors-servo
Auto merge of #26074 - jdm:transition-fix, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d06158a 
Avoid infinitely looping CSS transitions.

This change addresses the long-standing issue of CSS transitions not ending appropriately. It does not fundamentally change the way we process transitions/animations.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20379
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

💔 Test failed - status-taskcluster
@jdm
Avoid infinitely looping CSS transitions.
Loading status checks…
2bb6ab4
@jdm jdm force-pushed the jdm:transition-fix branch from 34709e3 to 2bb6ab4 Apr 1, 2020
@jdm
Copy link
Member Author

jdm commented Apr 1, 2020

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

📌 Commit 2bb6ab4 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

⌛ Testing commit 2bb6ab4 with merge e1ceb27...
bors-servo added a commit that referenced this pull request Apr 1, 2020
@bors-servo
Auto merge of #26074 - jdm:transition-fix, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e1ceb27 
Avoid infinitely looping CSS transitions.

This change addresses the long-standing issue of CSS transitions not ending appropriately. It does not fundamentally change the way we process transitions/animations.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20379
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Apr 1, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

⌛ Testing commit 2bb6ab4 with merge 516279e...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

☀️ Test successful - status-taskcluster
Approved by: SimonSapin
Pushing 516279e to master...
@bors-servo bors-servo merged commit 516279e into servo:master Apr 1, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
babylon.js perf issues automation moved this from In progress to Done Apr 1, 2020
@atouchet atouchet moved this from In progress to Done in HoloLens Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
babylon.js perf issues
  
Done
HoloLens
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

The `Idle` state is not always reached at the end of css transitions
4 participants
@jdm @highfive @bors-servo @SimonSapin
You can’t perform that action at this time.