Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the `box-sizing` property #26079

Merged
merged 6 commits into from Apr 1, 2020
Merged

Implement the `box-sizing` property #26079

merged 6 commits into from Apr 1, 2020
+3,956 −266

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Mar 31, 2020

No description provided.

SimonSapin added 6 commits Mar 31, 2020
@SimonSapin
Enable css-ui tests, for the 'box-sizing' property
ff27b72
@SimonSapin
Add expectations for newly-enabled css-ui tests
5f75f7f
@SimonSapin
Introduce a `PaddingBorderMargin` helper
0e35d70
@SimonSapin
Implement the `box-sizing` property
c377d9c
@SimonSapin
Less cloning
08801d9
@SimonSapin
Update WPT expectations
Loading status checks…
4bfe194
@SimonSapin SimonSapin added this to In progress in Layout 2020 via automation Mar 31, 2020
@highfive
Copy link

highfive commented Mar 31, 2020

Heads up! This PR modifies the following files:

  • @jgraham: tests/wpt/include-layout-2020.ini
  • @emilio: components/style/values/computed/length.rs, components/style/properties/longhands/position.mako.rs
@nox
Copy link
Member

nox commented Apr 1, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

📌 Commit 4bfe194 has been approved by nox
@highfive highfive assigned nox and unassigned paulrouget Apr 1, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

⌛ Testing commit 4bfe194 with merge 2c940c2...
bors-servo added a commit that referenced this pull request Apr 1, 2020
@bors-servo
Auto merge of #26079 - servo:box-sizing, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2c940c2 
Implement the `box-sizing` property
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

💔 Test failed - status-taskcluster
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 1, 2020

@bors-servo retry

  ▶ FAIL [expected PASS] /css/selectors/old-tests/css3-modsel-184c.xml
  │   → /css/selectors/old-tests/css3-modsel-184c.xml 4b06561a37597a7ebd72fd9312e8d8b48e63308b
  └   → /css/selectors/old-tests/css3-modsel-184-ref.xht d79e0de362c62267e1ebe323a65f04f91051eec7
  ▶ FAIL [expected PASS] /css/selectors/old-tests/css3-modsel-184f.xml
  │   → /css/selectors/old-tests/css3-modsel-184f.xml 4b06561a37597a7ebd72fd9312e8d8b48e63308b
  └   → /css/selectors/old-tests/css3-modsel-184-ref.xht d79e0de362c62267e1ebe323a65f04f91051eec7
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

⌛ Testing commit 4bfe194 with merge 5926577...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 5926577 to master...
@bors-servo bors-servo merged commit 5926577 into master Apr 1, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Layout 2020 automation moved this from In progress to Merged / resolved Apr 1, 2020
@bors-servo bors-servo deleted the box-sizing branch Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
A-layout/2020
Projects
Layout 2020
  
Merged / resolved
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@SimonSapin @highfive @nox @bors-servo @paulrouget
You can’t perform that action at this time.