Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Debian in mach bootstrap #26081

Merged
merged 1 commit into from Apr 1, 2020

Conversation

@dylan-lom
Copy link

dylan-lom commented Apr 1, 2020

Run apt-get commands (as written for Ubuntu), when context.distro is 'Debian GNU/Linux'.

This makes ./mach bootstrap install dependencies on Debian.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #26080 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

No test is included, I'm unsure how I would add one, since the changes are distro-dependant.

@highfive
Copy link

highfive commented Apr 1, 2020

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon.

@highfive
Copy link

highfive commented Apr 1, 2020

Heads up! This PR modifies the following files:

@jdm
Copy link
Member

jdm commented Apr 1, 2020

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

📌 Commit 16bb61b has been approved by jdm

@highfive highfive assigned jdm and unassigned SimonSapin Apr 1, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

Testing commit 16bb61b with merge ef2b986...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing ef2b986 to master...

@bors-servo bors-servo merged commit ef2b986 into servo:master Apr 1, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.