Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SpiderMonkey jitspew. #26086

Merged
merged 1 commit into from Apr 2, 2020
Merged

Support SpiderMonkey jitspew. #26086

merged 1 commit into from Apr 2, 2020

Conversation

@jdm
Copy link
Member

jdm commented Apr 1, 2020

This enables developers to diagnose JIT performance issues on desktop and on device by following the steps at https://github.com/servo/servo/wiki/Diagnosing-SpiderMonkey-JIT-issues.

@highfive
Copy link

highfive commented Apr 1, 2020

Heads up! This PR modifies the following files:

@highfive
Copy link

highfive commented Apr 1, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member

Manishearth commented Apr 1, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

📌 Commit 689b32c has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2020

Testing commit 689b32c with merge 9832fe8...

bors-servo added a commit that referenced this pull request Apr 1, 2020
Support SpiderMonkey jitspew.

This enables developers to diagnose JIT performance issues on desktop and on device by following the steps at https://github.com/servo/servo/wiki/Diagnosing-SpiderMonkey-JIT-issues.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 2, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member Author

jdm commented Apr 2, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Apr 2, 2020

Testing commit 689b32c with merge 5b9a822...

bors-servo added a commit that referenced this pull request Apr 2, 2020
Support SpiderMonkey jitspew.

This enables developers to diagnose JIT performance issues on desktop and on device by following the steps at https://github.com/servo/servo/wiki/Diagnosing-SpiderMonkey-JIT-issues.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 2, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member Author

jdm commented Apr 2, 2020

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Apr 2, 2020

Testing commit 689b32c with merge b895ccb...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 2, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing b895ccb to master...

@bors-servo bors-servo merged commit b895ccb into servo:master Apr 2, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 2, 2020
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.