Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ServiceWorker in multiprocess #26087

Merged
merged 2 commits into from Apr 5, 2020
Merged

Fix ServiceWorker in multiprocess #26087

merged 2 commits into from Apr 5, 2020

Conversation

@gterzian
Copy link
Member

gterzian commented Apr 1, 2020 •
edited

FIX #15217
FIX #26100

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented Apr 1, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/pipeline.rs, components/constellation/sandboxing.rs
  • @cbrewster: components/constellation/pipeline.rs, components/constellation/sandboxing.rs
@gterzian gterzian mentioned this pull request Apr 1, 2020
Closed
0 of 5 tasks complete
@gterzian gterzian force-pushed the gterzian:allow_service_workers_in_multiprocess branch from e7c0718 to 39cc57c Apr 1, 2020
@jdm
Copy link
Member

jdm commented Apr 2, 2020

I'm impressed by how much more readable the resulting infrastructure is here.
@gterzian gterzian force-pushed the gterzian:allow_service_workers_in_multiprocess branch 6 times, most recently from 896e62f to ad1f274 Apr 3, 2020
@gterzian
Copy link
Member Author

gterzian commented Apr 4, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Apr 4, 2020

⌛ Trying commit ad1f274 with merge 36520f5...
bors-servo added a commit that referenced this pull request Apr 4, 2020
@bors-servo
Auto merge of #26087 - gterzian:allow_service_workers_in_multiprocess…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
36520f5 
…, r=<try>

[WIP] Fix ServiceWorker in multiprocess

<!-- Please describe your changes on the following line: -->

FIX #15217
FIX #26100

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 4, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@gterzian gterzian changed the title [WIP] Fix ServiceWorker in multiprocess Fix ServiceWorker in multiprocess Apr 4, 2020
@gterzian
Copy link
Member Author

gterzian commented Apr 4, 2020

Ok this one is ready for review. @SimonSapin r? or @jdm r?
@gterzian gterzian force-pushed the gterzian:allow_service_workers_in_multiprocess branch from ad1f274 to 077c1bb Apr 4, 2020
@gterzian gterzian mentioned this pull request Apr 4, 2020
Open
@bors-servo
Copy link
Contributor

bors-servo commented Apr 4, 2020

☔ The latest upstream changes (presumably #26106) made this pull request unmergeable. Please resolve the merge conflicts.
@gterzian gterzian removed the S-needs-rebase label Apr 4, 2020
@gterzian gterzian force-pushed the gterzian:allow_service_workers_in_multiprocess branch from 077c1bb to 5883bf8 Apr 4, 2020
@CYBAI
Copy link
Collaborator

CYBAI commented Apr 4, 2020

👀

error[E0599]: no method named `register_with_background_hang_monitor` found for enum `constellation::sandboxing::UnprivilegedContent` in the current scope
    --> components/servo/lib.rs:1018:38
     |
1018 |                 unprivileged_content.register_with_background_hang_monitor()
     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `constellation::sandboxing::UnprivilegedContent`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0599`.
error: could not compile `libservo`.
@gterzian gterzian force-pushed the gterzian:allow_service_workers_in_multiprocess branch from 5883bf8 to acf9d95 Apr 4, 2020
@jdm
Copy link
Member

jdm commented Apr 4, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 4, 2020

📌 Commit acf9d95 has been approved by jdm
@highfive highfive assigned jdm and unassigned SimonSapin Apr 4, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2020

⌛ Trying commit 921ad76 with merge a3a0f2a...
bors-servo added a commit that referenced this pull request Apr 5, 2020
@bors-servo
Auto merge of #26087 - gterzian:allow_service_workers_in_multiprocess…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a3a0f2a 
…, r=<try>

Fix ServiceWorker in multiprocess

<!-- Please describe your changes on the following line: -->

FIX #15217
FIX #26100

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2020

💔 Test failed - status-taskcluster
@gterzian gterzian force-pushed the gterzian:allow_service_workers_in_multiprocess branch from 921ad76 to 8841083 Apr 5, 2020
@highfive highfive removed the S-tests-failed label Apr 5, 2020
@gterzian
Copy link
Member Author

gterzian commented Apr 5, 2020

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2020

⌛ Trying commit 8841083 with merge 1f1f488...
bors-servo added a commit that referenced this pull request Apr 5, 2020
@bors-servo
Auto merge of #26087 - gterzian:allow_service_workers_in_multiprocess…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1f1f488 
…, r=<try>

Fix ServiceWorker in multiprocess

<!-- Please describe your changes on the following line: -->

FIX #15217
FIX #26100

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2020

💔 Test failed - status-taskcluster
gterzian added 2 commits Apr 1, 2020
@gterzian
allow for a service worker manager per origin
db217d5
@gterzian
allow for a service worker network mediator per origin
Loading status checks…
1e017a7
@gterzian gterzian force-pushed the gterzian:allow_service_workers_in_multiprocess branch from 8841083 to 1e017a7 Apr 5, 2020
@highfive highfive removed the S-tests-failed label Apr 5, 2020
@gterzian
Copy link
Member Author

gterzian commented Apr 5, 2020 •
edited

@bors-servo r=jdm (I have since mainly moved some compiler flags around)
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2020

📌 Commit 1e017a7 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2020

⌛ Testing commit 1e017a7 with merge ade9fc9...
bors-servo added a commit that referenced this pull request Apr 5, 2020
@bors-servo
Auto merge of #26087 - gterzian:allow_service_workers_in_multiprocess…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ade9fc9 
…, r=jdm

Fix ServiceWorker in multiprocess

<!-- Please describe your changes on the following line: -->

FIX #15217
FIX #26100

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2020

📌 Commit 1e017a7 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2020

⌛ Testing commit 1e017a7 with merge ae49473...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing ae49473 to master...
@bors-servo bors-servo merged commit ae49473 into servo:master Apr 5, 2020
1 of 2 checks passed
1 of 2 checks passed
Community-TC (pull_request) TaskGroup: Pending (for pull_request.synchronize)
Details
homu Test successful
Details
@gterzian gterzian deleted the gterzian:allow_service_workers_in_multiprocess branch Apr 5, 2020
@bors-servo bors-servo mentioned this pull request Apr 5, 2020
Merged
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

ServiceWorker: allow for a network mediator per origin
Service worker code only supports a single content process
6 participants
@gterzian @highfive @jdm @bors-servo @CYBAI @SimonSapin
You can’t perform that action at this time.