Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for requersting RDP access from generic-worker #26102

Merged
merged 1 commit into from Apr 3, 2020
Merged

Add support for requersting RDP access from generic-worker #26102

merged 1 commit into from Apr 3, 2020

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Apr 3, 2020 •
edited

Fixes #26082

Depends on:
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 3, 2020

One missing piece is deciding when to request this access. At the moment it’s only enabled for tasks started for testing a new AMI. Enabling it for all Windows tasks would be costly since workers are kept around for 12 hours. All try=windows less so, but still feels more than necessary, but maybe that’s an ok compromise. Paul mentioned adding a Homu command for this, but that requires adding support for this in Homu itself.
@SimonSapin SimonSapin mentioned this pull request Apr 3, 2020
Closed
SimonSapin added a commit to servo/saltfs that referenced this pull request Apr 3, 2020
@SimonSapin
Add a `windows-rdp` try chooser
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b5cd231 
… for servo/servo#26102
@SimonSapin SimonSapin mentioned this pull request Apr 3, 2020
Merged
@SimonSapin
Request RDP access from generic-worker for `try=windows-rdp`
Loading status checks…
5b546dc
@SimonSapin SimonSapin changed the title [WIP] Add support for requersting RDP access from generic-worker Add support for requersting RDP access from generic-worker Apr 3, 2020
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 3, 2020

Based on discussion on Matrix, I’ve made this PR enable RDP for all Windows tasks in a new try branch (requires servo/saltfs#997) to be used with try=windows-rdp.
bors-servo added a commit to servo/saltfs that referenced this pull request Apr 3, 2020
@bors-servo
Auto merge of #997 - servo:SimonSapin-patch-1, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9c52821 
Add a `windows-rdp` try chooser

… for servo/servo#26102
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 3, 2020

@bors-servo try=windows-rdp
@bors-servo
Copy link
Contributor

bors-servo commented Apr 3, 2020

⌛ Trying commit 5b546dc with merge 51a1e81...
bors-servo added a commit that referenced this pull request Apr 3, 2020
@bors-servo
Auto merge of #26102 - servo:rdp, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
51a1e81 
Add support for requersting RDP access from generic-worker

Fixes #26082

Depends on:

* [x] mozilla/community-tc-config#252
* [x] servo/taskcluster-config#24
* [x] servo/saltfs#997
* [ ] mozilla/treeherder#6265 (for relevant tasks to show up in https://treeherder.mozilla.org/#/jobs?repo=servo-try)
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 3, 2020

Confirmed that I could connect to RDP with https://github.com/servo/taskcluster-config#mach-rdp-run-a-remote-desktop-client-for-a-windows-task for tasks created by Homu here. This is ready to land.

r? @paulrouget
@highfive highfive assigned paulrouget and unassigned Manishearth Apr 3, 2020
@paulrouget
Copy link
Contributor

paulrouget commented Apr 3, 2020

Thank you!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 3, 2020

📌 Commit 5b546dc has been approved by paulrouget
@bors-servo
Copy link
Contributor

bors-servo commented Apr 3, 2020

⌛ Testing commit 5b546dc with merge 7ba8824...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 3, 2020

☀️ Test successful - status-taskcluster
Approved by: paulrouget
Pushing 7ba8824 to master...
@bors-servo bors-servo merged commit 7ba8824 into master Apr 3, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the rdp branch Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paulrouget paulrouget

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Make it possible to start a Windows TC task that enables a RDP connection
5 participants
@SimonSapin @bors-servo @paulrouget @Manishearth @highfive
You can’t perform that action at this time.