Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck the BHM option before starting it in multi-process mode. #26106
Conversation
highfive
commented
Apr 3, 2020
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon. |
components/servo/lib.rs
Outdated
| background_hang_monitor_register, | ||
| None, | ||
| ); | ||
| if opts::get().background_hang_monitor { |
This comment has been minimized.
This comment has been minimized.
gterzian
Apr 4, 2020
Member
It might be clearer to do something like:
let background_hang_monitor_register = if opts::get().background_hang_monitor {
unprivileged_content.register_with_background_hang_monitor()
} else {
None
};
This comment has been minimized.
This comment has been minimized.
|
Thanks for the contribution, looks like the solution is right, with a small stylistic suggestion... |
qrasmont
force-pushed the
qrasmont:fix-26088-bhm-opt-in-multiproc
branch
from
cf73462
to
8b9390d
|
Looks good, and thanks for the contribution! |
|
@bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
qrasmont commentedApr 3, 2020
In multi-process mode, if the BHM option is set start with one otherwise don't.
I didn't add a test for this. However if I should I'd be happy to be pointed to where similar tests are done (meaning tests of options yielding the expected state) because I didn't find my way in all those tests.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThese changes fix #26088
There are tests for these changes OR
These changes do not require tests because they are minor enough to not require one.