Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InRealm argument to Callback trait #26116

Merged
merged 1 commit into from Apr 6, 2020
Merged

Add InRealm argument to Callback trait #26116

merged 1 commit into from Apr 6, 2020

Conversation

@tipowol
Copy link
Contributor

tipowol commented Apr 5, 2020

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #26007
  • There are tests for these changes
@tipowol
Add InRealm argument to Callback trait
Loading status checks…
8a3bf88
@highfive
Copy link

highfive commented Apr 5, 2020

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @paulrouget (or someone else) soon.
@highfive
Copy link

highfive commented Apr 5, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/testbinding.rs, components/script/dom/promisenativehandler.rs, components/script/dom/promise.rs, components/script/script_module.rs
  • @KiChjang: components/script/dom/testbinding.rs, components/script/dom/promisenativehandler.rs, components/script/dom/promise.rs, components/script/script_module.rs
@highfive
Copy link

highfive commented Apr 5, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@CYBAI
Copy link
Collaborator

CYBAI commented Apr 6, 2020

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Apr 6, 2020
@bors-servo
Auto merge of #26116 - tipowol:fix-26007, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0a99fa1 
Add InRealm argument to Callback trait

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26007
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2020

⌛ Trying commit 8a3bf88 with merge 0a99fa1...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@jdm
Copy link
Member

jdm commented Apr 6, 2020

@bors-servo r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2020

📌 Commit 8a3bf88 has been approved by jdm
@highfive highfive assigned jdm and unassigned paulrouget Apr 6, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2020

⌛ Testing commit 8a3bf88 with merge 51f1038...
bors-servo added a commit that referenced this pull request Apr 6, 2020
@bors-servo
Auto merge of #26116 - tipowol:fix-26007, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
51f1038 
Add InRealm argument to Callback trait

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26007
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Apr 6, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2020

⌛ Testing commit 8a3bf88 with merge 8126c9d...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 8126c9d to master...
@bors-servo bors-servo merged commit 8126c9d into servo:master Apr 6, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Add InRealm argument to Callback trait
6 participants
@tipowol @highfive @CYBAI @bors-servo @jdm @paulrouget
You can’t perform that action at this time.