Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update euclid #26130

Merged
merged 1 commit into from Apr 7, 2020
Merged

Update euclid #26130

merged 1 commit into from Apr 7, 2020

Conversation

@Manishearth
Copy link
Member

Manishearth commented Apr 7, 2020

r? @nox @jdm
@highfive
Copy link

highfive commented Apr 7, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/paintrenderingcontext2d.rs, components/script/dom/webgl2renderingcontext.rs, components/script/euclidext.rs, components/script/dom/canvasrenderingcontext2d.rs, components/script/canvas_state.rs and 2 more
  • @KiChjang: components/script/dom/paintrenderingcontext2d.rs, components/script/dom/webgl2renderingcontext.rs, components/script/euclidext.rs, components/script/dom/canvasrenderingcontext2d.rs, components/script/canvas_state.rs and 2 more
@highfive
Copy link

highfive commented Apr 7, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Manishearth Manishearth force-pushed the Manishearth:euclidup branch from d988d78 to 0854a2e Apr 7, 2020
@nox
Copy link
Member

nox commented Apr 7, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2020

📌 Commit 0854a2e has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2020

⌛ Testing commit 0854a2e with merge 95b969e...
bors-servo added a commit that referenced this pull request Apr 7, 2020
@bors-servo
Auto merge of #26130 - Manishearth:euclidup, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
95b969e 
Update euclid

r? @nox @jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Apr 7, 2020 

  ▶ Unexpected subtest result in /2dcontext/path-objects/2d.path.stroke.skew.html:
  └ PASS [expected FAIL] Strokes lines are skewed by the current transformation matrix
  ▶ Unexpected subtest result in /2dcontext/path-objects/2d.path.stroke.scale2.html:
  └ PASS [expected FAIL] Stroke line widths are scaled by the current transformation matrix
  ▶ Unexpected subtest result in /offscreen-canvas/path-objects/2d.path.stroke.scale2.html:
  └ PASS [expected FAIL] Stroke line widths are scaled by the current transformation matrix
  ▶ Unexpected subtest result in /offscreen-canvas/path-objects/2d.path.stroke.skew.worker.html:
  └ PASS [expected FAIL] Strokes lines are skewed by the current transformation matrix
  ▶ Unexpected subtest result in /offscreen-canvas/path-objects/2d.path.stroke.skew.html:
  └ PASS [expected FAIL] Strokes lines are skewed by the current transformation matrix
  ▶ Unexpected subtest result in /offscreen-canvas/path-objects/2d.path.stroke.scale2.worker.html:
  └ PASS [expected FAIL] Stroke line widths are scaled by the current transformation matrix
@jdm
Copy link
Member

jdm commented Apr 7, 2020

Looks like servo/euclid#377 fixed some bugs.
@Manishearth
Update euclid
Loading status checks…
fccfff1
@Manishearth Manishearth force-pushed the Manishearth:euclidup branch from 0854a2e to fccfff1 Apr 7, 2020
@Manishearth
Copy link
Member Author

Manishearth commented Apr 7, 2020

nice

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2020

📌 Commit fccfff1 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2020

⌛ Testing commit fccfff1 with merge 2002f49...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 2002f49 to master...
@bors-servo bors-servo merged commit 2002f49 into servo:master Apr 7, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Manishearth @highfive @nox @bors-servo @jdm
You can’t perform that action at this time.