Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for VertexAttribI4* and VertexAttribIPointer #26135

Merged
merged 2 commits into from Apr 7, 2020
Merged

Add initial support for VertexAttribI4* and VertexAttribIPointer #26135

merged 2 commits into from Apr 7, 2020

Conversation

@jdm
Copy link
Member

jdm commented Apr 7, 2020

Add initial support for the WebGL2 VertexAttribI4i, VertexAttribI4iv, VertexAttribI4ui, VertexAttribI4uiv and VertexAttribIPointer calls.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #26134 and fix #26123.
  • There are tests for these changes
@imiklos @jdm
Add initial support for VertexAttribI4*, VertexAttribIPointer
62f00df 
Adds initial support for the WebGL2 `VertexAttribI4i`, `VertexAttribI4iv`, `VertexAttribI4ui`, `VertexAttribI4uiv` and `VertexAttribIPointer` calls.
@highfive
Copy link

highfive commented Apr 7, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglvertexarrayobject.rs, components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webidls/WebGL2RenderingContext.webidl, components/script/dom/vertexarrayobject.rs, components/script/dom/webglrenderingcontext.rs and 2 more
  • @KiChjang: components/script/dom/webglvertexarrayobject.rs, components/script/dom/webglvertexarrayobjectoes.rs, components/script/dom/webidls/WebGL2RenderingContext.webidl, components/script/dom/vertexarrayobject.rs, components/script/dom/webglrenderingcontext.rs and 2 more
@highfive
Copy link

highfive commented Apr 7, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@jdm jdm changed the title Vertex attrib i4 Add initial support for VertexAttribI4* and VertexAttribIPointer Apr 7, 2020
@jdm
Copy link
Member Author

jdm commented Apr 7, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2020

📌 Commit 0f0382d has been approved by jdm
@highfive highfive assigned jdm and unassigned asajeffrey Apr 7, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2020

⌛ Testing commit 0f0382d with merge 10a9cab...
bors-servo added a commit that referenced this pull request Apr 7, 2020
@bors-servo
Auto merge of #26135 - jdm:vertex_attrib_i4, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
10a9cab 
Add initial support for VertexAttribI4* and VertexAttribIPointer

Add initial support for the WebGL2 `VertexAttribI4i`, `VertexAttribI4iv`, `VertexAttribI4ui`, `VertexAttribI4uiv` and `VertexAttribIPointer` calls.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26134 and fix #26123.
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2020

💔 Test failed - status-taskcluster
@jdm
webgl: Fix active uniform block length check.
Loading status checks…
66b2b32
@jdm jdm force-pushed the jdm:vertex_attrib_i4 branch from 0f0382d to 66b2b32 Apr 7, 2020
@jdm
Copy link
Member Author

jdm commented Apr 7, 2020

@bors-servo r+
@highfive highfive removed the S-tests-failed label Apr 7, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2020

📌 Commit 66b2b32 has been approved by jdm
bors-servo added a commit that referenced this pull request Apr 7, 2020
@bors-servo
Auto merge of #26135 - jdm:vertex_attrib_i4, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4f0e43d 
Add initial support for VertexAttribI4* and VertexAttribIPointer

Add initial support for the WebGL2 `VertexAttribI4i`, `VertexAttribI4iv`, `VertexAttribI4ui`, `VertexAttribI4uiv` and `VertexAttribIPointer` calls.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26134 and fix #26123.
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2020

⌛ Testing commit 66b2b32 with merge 4f0e43d...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Apr 7, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2020

⌛ Testing commit 66b2b32 with merge 7b5ec99...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 7b5ec99 to master...
@bors-servo bors-servo merged commit 7b5ec99 into servo:master Apr 7, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
This was referenced Apr 7, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

WebGLProgram::get_active_uniform_block_name compares index against wrong vector
5 participants
@jdm @highfive @bors-servo @asajeffrey @imiklos
You can’t perform that action at this time.