Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix webgl transform feedback #26143
Merged
Fix webgl transform feedback #26143
Conversation
…have no varying values.
highfive
commented
Apr 8, 2020
|
Heads up! This PR modifies the following files:
|
|
r? @nox |
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Apr 8, 2020
Fix webgl transform feedback This allows https://www.joshmatthews.net/webxr-particles/ to run in Servo. This change corresponds with the following spec text: ``` GL_INVALID_OPERATION is generated by glBeginTransformFeedback if no binding points would be used, either because no program object is active of because the active program object has specified no varying variables to record. ``` --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26137 - [x] There are tests for these changes
|
|
|
@nox review ping! |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 15, 2020
Fix webgl transform feedback This allows https://www.joshmatthews.net/webxr-particles/ to run in Servo. This change corresponds with the following spec text: ``` GL_INVALID_OPERATION is generated by glBeginTransformFeedback if no binding points would be used, either because no program object is active of because the active program object has specified no varying variables to record. ``` --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26137 - [x] There are tests for these changes
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedApr 8, 2020
•
edited
This allows https://www.joshmatthews.net/webxr-particles/ to run in Servo. This change corresponds with the following spec text:
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors