Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support WebGL2 contexts in immersive mode #26146

Merged
merged 1 commit into from Apr 8, 2020
Merged

Support WebGL2 contexts in immersive mode #26146

merged 1 commit into from Apr 8, 2020

Conversation

@jdm
Copy link
Member

jdm commented Apr 8, 2020

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #26138
@highfive
Copy link

highfive commented Apr 8, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/xrwebgllayer.rs, components/script/dom/webglframebuffer.rs, components/script/dom/webidls/XRWebGLLayer.webidl
  • @KiChjang: components/script/dom/xrwebgllayer.rs, components/script/dom/webglframebuffer.rs, components/script/dom/webidls/XRWebGLLayer.webidl
@jdm
Copy link
Member Author

jdm commented Apr 8, 2020

@bors-servo try=wpt
@highfive
Copy link

highfive commented Apr 8, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2020

⌛ Trying commit dcda3c5 with merge 9cf3adb...
bors-servo added a commit that referenced this pull request Apr 8, 2020
@bors-servo
Auto merge of #26146 - jdm:xr-webgl2, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9cf3adb 
Support WebGL2 contexts in immersive mode

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26138
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2020

💔 Test failed - status-taskcluster
@jdm
Support WebGL2 contexts in XRWebGLLayer.
Loading status checks…
c002a29
@jdm jdm force-pushed the jdm:xr-webgl2 branch from dcda3c5 to c002a29 Apr 8, 2020
@highfive highfive removed the S-tests-failed label Apr 8, 2020
@jdm
Copy link
Member Author

jdm commented Apr 8, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2020

⌛ Trying commit c002a29 with merge af3bce4...
bors-servo added a commit that referenced this pull request Apr 8, 2020
@bors-servo
Auto merge of #26146 - jdm:xr-webgl2, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
af3bce4 
Support WebGL2 contexts in immersive mode

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26138
@Manishearth
Manishearth approved these changes Apr 8, 2020
View changes
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
1 similar comment
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@jdm
Copy link
Member Author

jdm commented Apr 8, 2020

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2020

📌 Commit c002a29 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2020

⌛ Testing commit c002a29 with merge 4d8f63f...
bors-servo added a commit that referenced this pull request Apr 8, 2020
@bors-servo
Auto merge of #26146 - jdm:xr-webgl2, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4d8f63f 
Support WebGL2 contexts in immersive mode

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26138
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Apr 8, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2020

⌛ Testing commit c002a29 with merge 5e91e48...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 5e91e48 to master...
@bors-servo bors-servo merged commit 5e91e48 into servo:master Apr 8, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

webgl2 contexts don't render anything in immersive mode
4 participants
@jdm @highfive @bors-servo @Manishearth
You can’t perform that action at this time.