Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid GL errors with LineWidth commands #26147

Merged
merged 1 commit into from Apr 14, 2020
Merged

Avoid GL errors with LineWidth commands #26147

merged 1 commit into from Apr 14, 2020

Conversation

@jdm
Copy link
Member

jdm commented Apr 8, 2020

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #26139
@jdm
webgl: Avoid GL errors with LineWidth commands.
Loading status checks…
16d67b1
@jdm
Copy link
Member Author

jdm commented Apr 8, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2020

⌛ Trying commit 16d67b1 with merge dc01d4c...
bors-servo added a commit that referenced this pull request Apr 8, 2020
@bors-servo
Auto merge of #26147 - jdm:linewidth, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dc01d4c 
Avoid GL errors with LineWidth commands

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26139
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@jdm
Copy link
Member Author

jdm commented Apr 14, 2020

@nox review ping!
@nox
Copy link
Member

nox commented Apr 14, 2020

Oops, sorry for missing it. :/

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2020

📌 Commit 16d67b1 has been approved by nox
bors-servo added a commit that referenced this pull request Apr 14, 2020
@bors-servo
Auto merge of #26147 - jdm:linewidth, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a85dc77 
Avoid GL errors with LineWidth commands

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26139
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2020

⌛ Testing commit 16d67b1 with merge a85dc77...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Apr 14, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2020

⌛ Testing commit 16d67b1 with merge 23deec8...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 23deec8 to master...
@bors-servo bors-servo merged commit 23deec8 into servo:master Apr 14, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

LineWidth with non-1.0 value in webgl 2 contexts can cause a GL panic
4 participants
@jdm @bors-servo @nox @highfive
You can’t perform that action at this time.