Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDo not filter out platform objects when doing dictionary conversions in overload resolution #26154
Conversation
https://heycam.github.io/webidl/#es-overloads In step 12, the platform object check is for substep 4, but importantly it only matters if `V` implements the matching interface. If not, it should be able to fall back to substep 10 and attempt conversion to a dictionary.
highfive
commented
Apr 9, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Apr 9, 2020
|
|
|
r? @jdm @bors-servo try The specific thing triggering it was the following WebIDL and code: interface XRRay {
constructor(optional DOMPointInit origin = {}, optional DOMPointInit direction = {});
constructor(XRRigidTransform transform)
}new XRRay(new DOMPoint({x: 1, y: 0, z: 0}))I can wait for XRRay to land to add a test for this, or I can add stuff to TestBinding. Thoughts? |
bors-servo
added a commit
that referenced
this pull request
Apr 9, 2020
Do not filter out platform objects when doing dictionary conversions https://heycam.github.io/webidl/#es-overloads In step 12, the platform object check is for substep 4, but importantly it only matters if `V` implements the matching interface. If not, it should be able to fall back to substep 10 and attempt conversion to a dictionary.
Manishearth
changed the title
|
|
|
Testbinding would be my preference. |
|
Added a test |
|
@bors-servo r+ |
|
|
|
@bors-servo r- |
|
@bors-servo r=jdm |
|
|
Manishearth
force-pushed the
Manishearth:platform-object-overload
branch
from
a9c4f15
to
ee0ca1a
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 9, 2020
Do not filter out platform objects when doing dictionary conversions in overload resolution https://heycam.github.io/webidl/#es-overloads In step 12, the platform object check is for substep 4, but importantly it only matters if `V` implements the matching interface. If not, it should be able to fall back to substep 10 and attempt conversion to a dictionary.
Manishearth
force-pushed the
Manishearth:platform-object-overload
branch
from
ee0ca1a
to
58bab8a
|
@bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 9, 2020
Do not filter out platform objects when doing dictionary conversions in overload resolution https://heycam.github.io/webidl/#es-overloads In step 12, the platform object check is for substep 4, but importantly it only matters if `V` implements the matching interface. If not, it should be able to fall back to substep 10 and attempt conversion to a dictionary.
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Apr 9, 2020
Do not filter out platform objects when doing dictionary conversions in overload resolution https://heycam.github.io/webidl/#es-overloads In step 12, the platform object check is for substep 4, but importantly it only matters if `V` implements the matching interface. If not, it should be able to fall back to substep 10 and attempt conversion to a dictionary.
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedApr 9, 2020
https://heycam.github.io/webidl/#es-overloads
In step 12, the platform object check is for substep 4, but importantly it only matters if
Vimplements the matching interface. If not, it should be able to fall back to substep 10 and attempt conversion to a dictionary.