Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assertion for negative value from get_uniform_location #26163

Merged
merged 1 commit into from Apr 10, 2020
Merged

Remove assertion for negative value from get_uniform_location #26163

merged 1 commit into from Apr 10, 2020

Conversation

@dralley
Copy link
Contributor

dralley commented Apr 10, 2020 •
edited

closes #26150

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #26150 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@dralley
Remove assertion for negative value from get_uniform_location
Loading status checks…
865b538 
closes #26150
@jdm
Copy link
Member

jdm commented Apr 10, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2020

⌛ Trying commit 865b538 with merge d3f04af...
bors-servo added a commit that referenced this pull request Apr 10, 2020
@bors-servo
Auto merge of #26163 - dralley:remove-assertion, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d3f04af 
Remove assertion for negative value from get_uniform_location

closes #26150

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26150 (GitHub issue number if applicable)
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@jdm
Copy link
Member

jdm commented Apr 10, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2020

📌 Commit 865b538 has been approved by jdm
@highfive highfive assigned jdm and unassigned nox Apr 10, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2020

⌛ Testing commit 865b538 with merge dccaa43...
bors-servo added a commit that referenced this pull request Apr 10, 2020
@bors-servo
Auto merge of #26163 - dralley:remove-assertion, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dccaa43 
Remove assertion for negative value from get_uniform_location

closes #26150

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26150 (GitHub issue number if applicable)
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2020

💔 Test failed - status-taskcluster
@gterzian
Copy link
Member

gterzian commented Apr 10, 2020 

5 unexpected results that are NOT known-intermittents:
  ▶ TIMEOUT [expected OK] /webaudio/the-audio-api/the-audioparam-interface/setValueAtTime-within-block.html
  ▶ TIMEOUT [expected OK] /html/semantics/embedded-content/media-elements/event_loadedmetadata_noautoplay.html
  ▶ TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function-parent.html
  ▶ TIMEOUT [expected OK] /webaudio/the-audio-api/the-audioparam-interface/audioparam-exceptional-values.html
  │ 
  │ _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
  │ 
  │ 
  └ 
  ▶ TIMEOUT [expected OK] /webaudio/the-audio-api/the-audioparam-interface/audioparam-linearRampToValueAtTime.html
  │ 
  │ _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
  │ 
  │ 
  └ 

1 unexpected results that are NOT known-intermittents:
  ▶ TIMEOUT [expected ERROR] /css/cssom-view/scroll-behavior-subframe-root.html
  │ 
  │ 
  │ 
  │ 
  └ [2020-04-10T04:34:17Z ERROR script::dom::bindings::error] Error at http://web-platform.test:8000/css/cssom-view/scroll-behavior-subframe-root.html:37:3 iframeNode is not defined

Appears unrelated
@CYBAI
Copy link
Collaborator

CYBAI commented Apr 10, 2020

@bors-servo retry

  • I think they are #25513 👀
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2020

⌛ Testing commit 865b538 with merge 5e30d2f...
bors-servo added a commit that referenced this pull request Apr 10, 2020
@bors-servo
Auto merge of #26163 - dralley:remove-assertion, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5e30d2f 
Remove assertion for negative value from get_uniform_location

closes #26150

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26150 (GitHub issue number if applicable)
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Apr 10, 2020

@bors-servo retry

  ▶ TIMEOUT [expected OK] /offscreen-canvas/fill-and-stroke-styles/2d.gradient.interpolate.zerosize.stroke.html
  ▶ TIMEOUT [expected OK] /offscreen-canvas/fill-and-stroke-styles/2d.fillStyle.parse.invalid.rgba-3.worker.html

(are they also #25513?)
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2020

⌛ Testing commit 865b538 with merge e43cadb...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing e43cadb to master...
@bors-servo bors-servo merged commit e43cadb into servo:master Apr 10, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@dralley dralley deleted the dralley:remove-assertion branch Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Remove assertion for negative value from get_uniform_location
7 participants
@dralley @jdm @bors-servo @gterzian @CYBAI @nox @highfive
You can’t perform that action at this time.